Disable keyboard shortcuts whenever editing text

[Luke Bayes]

Hey Folks,

First up, I am incredibly grateful for all the hard work everyone has put into this project. It really is remarkable. Thank you!

Second, I sent a message with a patch to the group on Saturday, but I haven't seen it come through and I'm concerned I may have botched the send operation from the Groups web app.

Trying again from my email client here, please forgive me if the other message is in a moderation queue, I don't mean to rush anyone. I know how much work it is to manage a community like this.

Finally, I ran into this issue last week and thought I'd take a stab at resolving it.

I was editing a bunch of text fields for a project set up and I habitually press, "CTRL+SHIFT+ARROW" to select words.

This causes the selected HEAD to (unexpectedly) move on the machine, which could cause a crash.

I introduced a patch that blocks keyboard shortcuts if the focused UI control is a text input.

Here is the diff:

https://github.com/openpnp/openpnp/compare/main...lukebayes:openpnp:lbj-ctrlshift

I wanted to check in here before submitting a full PR to see what folks think.

Thanks!

Luke Bayes

Eight Amps

[vespaman]

Ouch!

That sounds like a horrible experience, I think it could also happen to me (it hasn't yet). So I think a PR sounds good. I'm not a maintainer though, but I build my own OpenPnP from sources to include all the PR's that I need, so from that perspective, a PR is welcome. :-)

  - Micael

[Luke Bayes]

Thanks for the kind words!

I'll go ahead and push a PR.

Thanks,

Luke

 

--
You received this message because you are subscribed to the Google Groups "OpenPnP" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openpnp+u...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/openpnp/c7a0a507-b19a-4496-8a85-5d4a78265ad6n%40googlegroups.com.