SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/bb76a227-fcf8-4f29-9a77-c5862b60a7d6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Hello Jakub,
I wanted to raise that this may be a globally applicable feature. In https://openlmis.atlassian.net/browse/OLMIS-401 we decided to use the UUID because with system integrations we would want to use the UUID. However, has you point out it is challenging for print-outs or when a manual transcribing process is followed (copying the Order Number to another paper form).
As Josh mentions, please create a JIRA ticket with the story that supports the configuration of the order number. Once created, I believe the PC would find this feature globally applicable and the PC can review. It may be easier to build out the feature versus using an extension point.
In terms of releases, we are planning to wait one more sprint for the 3.2.1 release so we'd have time to write up the ticket and complete it prior to the release.
Thanks,
Mary Jo
Hi.
yes, this is a priority for Malawi and we need to incorporate
this feature as soon as possible.
Josh, I'm quite surprised to see all those requirements we
must meet in order to implement a simple extension point and an
extension module. Wasn't the initial idea of the extension points
to have a simple way for implementations to alter behavior of
certain parts of the logic, mostly on their own? Last time we
spoke about the workflow for implementations to implement ext
point/module, my impression was that exposing an extension point
was meant to be conisdered a trivial (non-controversial) change
that can be submitted to core's code pretty much anytime (since
it's just a refactor of some piece of a code to reside in a spring
bean). Has anything changed since then or did I not understand
what the workflow for providing an extension point is? If
implementing an extension point requires implementations to
provide the detailed use case, technical design, interface code,
explanation of the approach and getting an approval from the
product committee and technical committee, I'm afraid we may not
see any extension point implemented in OpenLMIS v3. Perhaps we
could revisit the workflow at the next technical committee call?
Please don't get me wrong - the Malawi team can of course provide
all of this if it seems necessary. The above is really a concern
for new/outside implementations. If we are to discourage forking,
we are not doing it right (or at all) at the moment.
Mary Jo, thanks for your response. If this is something that is globally applicable this would make things easier for us. When do you think you would be able to get PC feedback on it? As I mentioned this is a high priority change for us, therefore knowing whether we will be implementing it directly in core or via extension point is crucial for us.
Best regards,
Sebastian.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/MWHPR0201MB3545DA3840583BCCB7E93CE58F690%40MWHPR0201MB3545.namprd02.prod.outlook.com.
For more options, visit https://groups.google.com/d/optout.
Sebastian
Brudziński
Software Developer / Team Leader
sbrud...@soldevelo.com
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/3e9bbca5-daad-2bc3-949c-ce1f4aba7853%40soldevelo.com.
From: openlmis-dev@googlegroups.com <openlmis-d...@googlegroups.com> on behalf of Josh Zamor <josh.zamor@villagereach.org>
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlmis-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/bb76a227-fcf8-4f29-9a77-c5862b60a7d6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlmis-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/C43B23A4-60DD-4264-A676-280D736FCC0A%40villagereach.org.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlmis-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/MWHPR0201MB3545DA3840583BCCB7E93CE58F690%40MWHPR0201MB3545.namprd02.prod.outlook.com.
For more options, visit https://groups.google.com/d/optout.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlmis-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/3e9bbca5-daad-2bc3-949c-ce1f4aba7853%40soldevelo.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/977FDE21-A302-4A0D-87B1-EB0A14C03D49%40villagereach.org.
I also feel we already have enough of a user story already - easier to read order numbers.
Hi Josh,
A user story can be found here:
https://openlmis.atlassian.net/browse/MW-475
Regarding our bean that would implement the extension: I was thinking that Base36 with 6 characters would be good - it's short and case insensitive which would make it easier for people writing them down. I believe it has around 2 billion combinations, so we could additionally check for its uniqueness in that extension point. Base36OrderCodeGenerator?
I went ahead and created the proposed extension point (not much overhead since we already had the code in example service). It can be found on order-code-extension branch. Here's the interface:
And here's the code that uses the created order number:
I also modified the ExtensionManager a little so that when it has no configuration entry it looks for a bean with given class - as a result I could run fulfillment service without any additional docker images (openlmis-fulfillment-extensions?) and it still used the default implementation.
-JakubTo unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/5D8A20DC-9CED-4A19-8463-95DC5FCEAD06%40villagereach.org.
For more options, visit https://groups.google.com/d/optout.
Jakub Kondrat
Software Developer
jkon...@soldevelo.com
SolDevelo Sp. z o. o. [LLC]
Office: +48 58 782 45 40 / Fax: +48 58 782 45 41 Al. Zwycięstwa 96/98 81-451, Gdynia
http://www.soldevelo.com
Place of registration: Regional Court for the City of
Gdansk KRS: 0000332728, TAX ID:
PL5862240331, REGON: 220828585, Share capital:
60,000.00 PLN
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/25378009-36fa-4cca-ccfe-86cc83cdfc2a%40soldevelo.com.