--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53x6Gr76fP_F1Y2jKcjhBuKfxwsb7_kOnrb0POeoJo197g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAGOM9mVasVLqnTnq2v1mKWub2mgbS8%3DOMkixYSx1dFoGn4Ja_g%40mail.gmail.com.
Thanks for the quick reply, Chongsun.
Łukasz, can you create tickets for this work, based on the output of the discussion and add them to our current sprint?
Thanks,
Sebastian.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/67768C56-97A2-4E1C-83FC-C420B964C741%40villagereach.org.
For more options, visit https://groups.google.com/d/optout.
Sebastian
Brudziński
Senior Software Developer / Team
Leader
sbrud...@soldevelo.com
Thanks for the quick reply, Chongsun.
Łukasz, can you create tickets for this work, based on the output of the discussion and add them to our current sprint?
Thanks,
Sebastian.
On 07.03.2018 16:25, Chongsun Ahn wrote:
Hey Łukasz,
The concept of different screens only requiring the corresponding rights (ORDERS_VIEW for orders screen, SHIPMENTS_VIEW for shipments screen, etc.) makes sense to me. The reason why we decided to stop using the expanded pattern is because it’s not very RESTful (see https://github.com/OpenLMIS/openlmis-template-service/blob/master/STYLE-GUIDE.md#restful-interface-design--documentation) and it can create large responses where most of the data is not used by the API client. However, the expanded pattern is useful and perhaps necessary in some cases, as we see here—but we should not try to make it the default pattern.
So I would suggest supporting the expanded pattern as an option on GET shipment and PoD endpoints, but not to make it the default. We already use that pattern for getting an order. As for your other proposal points, they sound good.
Shalom,
Chongsun
--
There are 10 kinds of people in this world; those who understand binary, and those who don’t.
Chongsun Ahn | chongsun.ahn@villagereach.org
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAGOM9mVasVLqnTnq2v1mKWub2mgbS8%3DOMkixYSx1dFoGn4Ja_g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/67768C56-97A2-4E1C-83FC-C420B964C741%40villagereach.org.
For more options, visit https://groups.google.com/d/optout.
--
Sebastian Brudziński
Senior Software Developer / Team Leader
sbrud...@soldevelo.com
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
I created two tickets:
- OLMIS-4266 - to provide expand pattern to endpoints and use them by UI
- OLMIS-4267 - to verify that endpoints required correct rights
Thanks,
Lukasz
On Wed, Mar 7, 2018 at 4:33 PM, Sebastian Brudziński <sbrud...@soldevelo.com> wrote:
Thanks for the quick reply, Chongsun.
Łukasz, can you create tickets for this work, based on the output of the discussion and add them to our current sprint?
Thanks,
Sebastian.
On 07.03.2018 16:25, Chongsun Ahn wrote:
Hey Łukasz,
The concept of different screens only requiring the corresponding rights (ORDERS_VIEW for orders screen, SHIPMENTS_VIEW for shipments screen, etc.) makes sense to me. The reason why we decided to stop using the expanded pattern is because it’s not very RESTful (see https://github.com/OpenLMIS/openlmis-template-service/blob/master/STYLE-GUIDE.md#restful-interface-design--documentation) and it can create large responses where most of the data is not used by the API client. However, the expanded pattern is useful and perhaps necessary in some cases, as we see here—but we should not try to make it the default pattern.
So I would suggest supporting the expanded pattern as an option on GET shipment and PoD endpoints, but not to make it the default. We already use that pattern for getting an order. As for your other proposal points, they sound good.
Shalom,
Chongsun
--
There are 10 kinds of people in this world; those who understand binary, and those who don’t.
Chongsun Ahn | chongs...@villagereach.org
To unsubscribe from this group and stop receiving emails from it, send an email to ...@googlegroups.com.
To post to this group, send email to ...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53x6Gr76fP_F1Y2jKcjhBuKfxwsb7_kOnrb0POeoJo197g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to ...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAGOM9mVasVLqnTnq2v1mKWub2mgbS8%3DOMkixYSx1dFoGn4Ja_g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/67768C56-97A2-4E1C-83FC-C420B964C741%40villagereach.org.
For more options, visit https://groups.google.com/d/optout.
--
Sebastian Brudziński
Senior Software Developer / Team Leader
sbrud...@soldevelo.com
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/283d3fd4-df20-445f-938b-a4572d777e34%40googlegroups.com.
Just to chime in - I wouldn't call it a connection. It's just the
ability to search a proof of delivery by the orderId - which can
yield no results and that's perfectly fine. I agree though that
all our fulfillment UI views use order in one way or another - if
we decide to ever support orderless shipments (which also produces
orderless PODs) we will need to do redesign those screens.
Best regards,
Sebastian.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53wTbvq1MjbzSLmwun-rP-czW8-k8H4A%2BaRD3foAziMX2A%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Sebastian
Brudziński
Senior Software Developer / Team
Leader
sbrud...@soldevelo.com
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53wTbvq1MjbzSLmwun-rP-czW8-k8H4A%2BaRD3foAziMX2A%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/180e4ff2-7d93-a57e-9cd5-c11074657b16%40soldevelo.com.