--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/139e74ee-684c-4632-a14f-6b253b0137b1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
I don't know the intended scope of this ticket.
If it were up to me I would want to include making the keys and values of a properties file be plain strings (and bean IDs) rather than full classnames.
Josh, do we have any prior research on what the extensions will be, e.g. "most likely...Java interfaces" means that the test are what?
-Darius (by phone)
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/2ff9096d-a360-4dbe-804c-af03b069f9e9%40googlegroups.com.
Hello,
is there any update on these extension point tickets? Can we move
forward with transitioning them to done? They have been in review
for a while now.
Regards,
Paweł
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/8c5d59e8-27f0-4327-8985-4fc6568f7785%40googlegroups.com.
After discussing with the team, we want to wait for Darius to get back and review. Apologies for the confusion.
From: openlm...@googlegroups.com [mailto:openlm...@googlegroups.com]
On Behalf Of Mary Jo Kochendorfer
Sent: Wednesday, August 24, 2016 9:19 AM
To: Paweł Gesek <pge...@soldevelo.com>
Cc: OpenLMIS Dev (openlm...@googlegroups.com) <openlm...@googlegroups.com>
Subject: RE: [openlmis-dev] Example extension module repository
Folks,
- If we want to make things easier for the implementer to configure, we could have some sort of plain text configuration file rather than serialized beans as xml. (If that's not a priority, fine.)
- the extension point IDs should be strings that we intentionally come up with, not the fully-qualified classnames. (I.e. something like "OrderQuantityCalculationAlgorithm" instead of "org.openlmis.example.extensionpoint.OrderQuantity")
- also, the extension value should be a string (like a bean ID) rather than a fully-qualified classname (for example we might have a utility class that we instantiate into multiple beans, like a LuhnModNCheckDigitIdGenerator)
ExtensionManager
- I would expect a test for this class, and that's where I'd look to see how it behaves. (Yes, I know this is example code, but the idea is that we're bringing this into the real codebase, right? TDD!)
- getImplementation method:
- As a consumer I'd expect a method like getExtensionByPointId(String)
- javadoc should say whether this returns null
- getExtendedImplementation method need better behavior in case the specified extension doesn't exist
- I would put this class under the "extension" package (and move the points to extension.point)
Extension
- extensions should be able to be more than just a classname. e.g. we might want a list of classes
DefaultImplementation annotation:
- My initial reaction (assuming we want to make things easier for the implementer) is that we're better off with a "default config" file (which is then overridden by the extensions config file), and thus this annotation is not needed.
Usage
- I would expect that the main service is built and published to a maven repository, and this becomes a plain dependency specified in build.gradle (instead of each dev having to specify mainProjectPath as a local path). Dev shouldn't even strictly need to check out the service code to be able to write an extension.
- we should spike on having an annotation that can be used in place of @Autowired, and automatically sets a property via ExtensionManager
-Darius
On Thu, Jul 28, 2016 at 9:04 AM, Weronika Ciecierska <wciec...@soldevelo.com> wrote:
Hello everyone,
As you probably know, proof of concept of work on extension points and modules was published to openlmis-example repository recently.
Today I created new repository that contains example extension module - https://github.com/weronika-ciecierska/openlmis-example-extension
That means that it is no longer needed to download JAR file from my previous mail to test an example extension point from openlmis-example. Now it is possible to test it using this repository.
It is also possible to add your own extension points and extensions to see how everything works. There is detailed description in README on how to do it.
I think that our next step should be moving this repository to OpenLMIS account.
I encourage everyone to take a look at this and write your opinion. If you have any questions I will be happy to answer them.
Best regards,
Weronika--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/139e74ee-684c-4632-a14f-6b253b0137b1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Darius JazayeriPrincipal Architect - Global Health
Telephone
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/2ff9096d-a360-4dbe-804c-af03b069f9e9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/8c5d59e8-27f0-4327-8985-4fc6568f7785%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
openlmis-dev...@googlegroups.com.
To post to this group, send email to
openlm...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/687758f4-cdad-d92f-e6e2-9b2f62013a64%40soldevelo.com.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/8c5d59e8-27f0-4327-8985-4fc6568f7785%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/687758f4-cdad-d92f-e6e2-9b2f62013a64%40soldevelo.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/DM5PR02MB23455FD5A4BE46EFF7B87DF98FEA0%40DM5PR02MB2345.namprd02.prod.outlook.com.