Thanks for bringing this up. Our current JavaScript Coding Conventions are here: http://docs.openlmis.org/en/latest/conventions/uiJavascript.html
Is the Google JavaScript Guide you are proposing compatible with our existing conventions? In other words, is the Google JavaScript Guide just an addition to our current conventions? Or does your proposal involve changing what we already have?
-Brandon
From: <openlm...@googlegroups.com> on behalf of Łukasz Lewczyński <llewc...@soldevelo.com>
Date: Friday, March 16, 2018 at 1:03 AM
To: OpenLMIS Dev <openlm...@googlegroups.com>, Nikodem Graczewski <ngrac...@soldevelo.com>
Subject: [openlmis-dev] Google's Javascript Style Guide
On our last Sprint Retrospective we decided that we should add something like checktyle/pmd validation to our JavaScript code because code is not consistent and sometimes we need to adjust code because of review comments.
I checked and found that there is the Google guide for JS code and I think because we implement similar guide for Java we could use this one for JS code. Below you can find useful links.
Google javaScript Guide
Eslint configuration:
Any thoughts?
Regards,
Lukasz
Łukasz Lewczyński
Software Developer
llewc...@soldevelo.com
SolDevelo Sp. z o.o. [LLC] /
www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
openlmis-dev...@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53wwwcnB7i0kVV%2B6BWxNJCtP1O1avU6jTXejD9ni4U5WuQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/F9CAD08B-D5F3-49A8-B2C6-C2F5AFCED836%40villagereach.org.
Hi Łukasz,Is Google's Javascript Style Guide compatible with our current tech stack?Regards,Paweł
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAJzpfmzFz9vqxZz6gB88OOvQw0rK1tf%2B-P-_68dOXFV_SMQ0g%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53yQFuzdmcq%2BBmR175CNd-pZ82XCv44yO_6DK0dJNqWeAw%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CADt-Nu0V6F24AtuAjdrbxhP4h5QRZxrGzgjCU7kF2z4qTMMp1w%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAHq-FDP2QCADmvkHdSYD8iibsNiNegY2Wtr%2B72OcMBcOEsbgnA%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CADt-Nu3YNuSMgVark_zPSrbyqfGcEQgVOP14BQe%2BjXBFaCrXpg%40mail.gmail.com.
I support the idea of making a ticket to research JavaScript linters for our Sonar. If there is a linter configuration that enforces our current John Papa coding conventions, that would be best from my perspective. I know Nick was a supporter of the John Papa conventions; just because Nick left the project is not a good reason to change our convention and re-format all of our JavaScript codebase. So automating the checking to enforce our current conventions feels like the right thing for us to do.
-Brandon
Error! Filename not specified.
SolDevelo Sp. z o.o. [LLC] /
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit
For more options, visit https://groups.google.com/d/optout.
--
Paweł Albecki
Software Developer
palb...@soldevelo.com
Error! Filename not specified.
SolDevelo Sp. z o.o. [LLC] /
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit
For more options, visit https://groups.google.com/d/optout.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53yQFuzdmcq%2BBmR175CNd-pZ82XCv44yO_6DK0dJNqWeAw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
--
Paweł Gesek
Technical Project Manager
pge...@soldevelo.com / +48 690 020 875
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CADt-Nu0V6F24AtuAjdrbxhP4h5QRZxrGzgjCU7kF2z4qTMMp1w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit
For more options, visit https://groups.google.com/d/optout.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CADt-Nu3YNuSMgVark_zPSrbyqfGcEQgVOP14BQe%2BjXBFaCrXpg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
SolDevelo Sp. z o.o. [LLC] /
www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to
openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAGOM9mXUboGsHvDu6TUa7rRxMz%3D8uhSFJoRB6BR2VoObXq35Eg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit
For more options, visit https://groups.google.com/d/optout.
--
Paweł Albecki
Software Developer
palb...@soldevelo.com
Error! Filename not specified.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit
For more options, visit https://groups.google.com/d/optout.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53yQFuzdmcq%2BBmR175CNd-pZ82XCv44yO_6DK0dJNqWeAw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
--
Paweł Gesek
Technical Project Manager
pge...@soldevelo.com / +48 690 020 875
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CADt-Nu0V6F24AtuAjdrbxhP4h5QRZxrGzgjCU7kF2z4qTMMp1w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit
For more options, visit https://groups.google.com/d/optout.
--
Paweł Gesek
Technical Project Manager
pge...@soldevelo.com / +48 690 020 875
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CADt-Nu3YNuSMgVark_zPSrbyqfGcEQgVOP14BQe%2BjXBFaCrXpg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
To view this discussion on the web visit
--
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/85687FEE-43B3-4C66-ACD1-5F1494036446%40villagereach.org.