opencog utest failing

51 views
Skip to first unread message

Nil Geisweiller

unread,
Oct 21, 2016, 1:35:21 AM10/21/16
to opencog
Hi,

multiple tests on the opencog repo fail, some are mine and I was let
unaware of it. I don't dare to do my next changes till these tests get
fixed cause I want to be confident it won't break existing things.

Obviously we need to improve buildbot notification on failure. Is it
possible to set up mail notification? Or have the buildbot mention the
culprit (or @channel) in the slack channel whenever it fails?

Thanks,
Nil

AmeBel

unread,
Oct 23, 2016, 11:32:24 PM10/23/16
to opencog
Hi,

there is a builds channel on slack.

Nil Geisweiller

unread,
Oct 24, 2016, 3:10:38 AM10/24/16
to ope...@googlegroups.com
Hi,

yes I know that, what I suggest is that whenever the builds fails we get
notified, as opposed to the build channel turns bold no matter what.

One trick would be to add the mention "@channel" inside the message only
when it fails.

Nil
> --
> You received this message because you are subscribed to the Google
> Groups "opencog" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to opencog+u...@googlegroups.com
> <mailto:opencog+u...@googlegroups.com>.
> To post to this group, send email to ope...@googlegroups.com
> <mailto:ope...@googlegroups.com>.
> Visit this group at https://groups.google.com/group/opencog.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/opencog/00fc6deb-71d3-4bd6-a257-2592b5ec7076%40googlegroups.com
> <https://groups.google.com/d/msgid/opencog/00fc6deb-71d3-4bd6-a257-2592b5ec7076%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.

AmeBel

unread,
Oct 24, 2016, 6:01:35 AM10/24/16
to opencog
Changes have been made such that build channel turns bold only when there are failures.



Linas Vepstas

unread,
Oct 24, 2016, 2:32:02 PM10/24/16
to opencog
I just finished recovering from a failed graphics card... am a bit behind.
-- the two python utests in opencog have been failing for a while ... the failures are "trite", having to do with broken handling of print statements.
-- sureal started failing after a recent link-grammar update, presumably something in sureal depends in an unexpected way on link-grammar.  I have not dug into this.

-- I recall seeing something else fail, but have not looked since my hardware update; I thought it was somethingthat nil broke...

Linas

On Mon, Oct 24, 2016 at 5:01 AM, AmeBel <am...@hansonrobotics.com> wrote:
Changes have been made such that build channel turns bold only when there are failures.



--
You received this message because you are subscribed to the Google Groups "opencog" group.
To unsubscribe from this group and stop receiving emails from it, send an email to opencog+unsubscribe@googlegroups.com.
To post to this group, send email to ope...@googlegroups.com.

Nil Geisweiller

unread,
Oct 24, 2016, 4:49:50 PM10/24/16
to ope...@googlegroups.com
On 10/24/2016 01:01 PM, AmeBel wrote:
> Changes have been made such that build channel turns bold only when
> there are failures.

It's cool, thanks. But I think a notification would even be better. If
`@channel` appears in the message then we'll be notified by email as well.

Having the unit tests failing has become inconvenient. People tend to
loose track of what passes and what doesn't and can no longer use it has
a bug detector for their changes. We don't want to go back to branch
protection which is pain, but we need a notification system which is as
loud as possible.

Nil

>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "opencog" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to opencog+u...@googlegroups.com
> <mailto:opencog+u...@googlegroups.com>.
> To post to this group, send email to ope...@googlegroups.com
> <mailto:ope...@googlegroups.com>.
> Visit this group at https://groups.google.com/group/opencog.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/opencog/11e8b796-2063-450f-bbe9-56bde34947b8%40googlegroups.com
> <https://groups.google.com/d/msgid/opencog/11e8b796-2063-450f-bbe9-56bde34947b8%40googlegroups.com?utm_medium=email&utm_source=footer>.
Reply all
Reply to author
Forward
0 new messages