C implementation provided

108 views
Skip to first unread message

Gonzalo Diethelm

unread,
Mar 22, 2018, 3:47:16 PM3/22/18
to open-location-code
Hello everyone,

I have implemented the library in C, using the C++ implementation as inspiration / ideas / base. My implementation is on github: https://github.com/gonzus/olc

I am happy to contribute this to the project, whether by moving it into the project's github repo, or by you guys linking to my implementation.

Cheers,
Gonzalo Diethelm

ahmad ali

unread,
Apr 15, 2018, 8:18:47 PM4/15/18
to open-location-code

Zongwei Li

unread,
May 25, 2018, 5:39:29 PM5/25/18
to Plus Codes Community Forum
Hey Gonzalo,

Thanks for letting us know about your C implementation. We'd be happy to include it as part of the main repo (with attribution, of course). Can you send a pull request?

Joshua Saxby

unread,
Oct 18, 2018, 3:54:19 PM10/18/18
to Plus Codes Community Forum
Hi Gonzalo!

Wow, it's nice to see that in the time that I spent *not* doing this, someone else picked up the mantle and created a C implementation!

Great work!

J.S.

Gonzalo Diethelm

unread,
Oct 18, 2018, 4:25:41 PM10/18/18
to zon...@google.com, open-loca...@googlegroups.com
Oh wow. I just noticed I never saw your reply. I will send a pull request soon.

Cheers,
Gonzalo


--
Public site: http://www.openlocationcode.com/
Github project: https://github.com/google/open-location-code
Demo site: http://plus.codes/
---
You received this message because you are subscribed to a topic in the Google Groups "Plus Codes Community Forum" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/open-location-code/U8IvkYy8dFg/unsubscribe.
To unsubscribe from this group and all its topics, send an email to open-location-c...@googlegroups.com.
To post to this group, send email to open-loca...@googlegroups.com.
Visit this group at https://groups.google.com/group/open-location-code.
To view this discussion on the web, visit https://groups.google.com/d/msgid/open-location-code/2e6158e8-aad6-40cb-929d-7f2dacaefd37%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--
Gonzalo Diethelm
gonzalo....@gmail.com

Zongwei Li

unread,
Oct 30, 2018, 12:58:56 PM10/30/18
to gonzalo....@gmail.com, open-loca...@googlegroups.com
Hey Gonzalo,

Just wanted to make sure I didn't miss your pull request. Have you sent it out yet?

Gonzalo Diethelm

unread,
Oct 30, 2018, 3:02:17 PM10/30/18
to Zongwei Li, open-loca...@googlegroups.com
Hi Zongwei (or is it Li?),

No, sorry, just came back from a week of holiday. I intend to send it over this coming weekend. I will also post here when I finally do it.

Cheers,
Gonzalo

--
Gonzalo Diethelm
gonzalo....@gmail.com

Gonzalo Diethelm

unread,
Oct 31, 2018, 3:39:06 AM10/31/18
to Zongwei Li, open-loca...@googlegroups.com
I just created the PR.

Caveat: the implementation uses a simple Makefile; it was easier for me this way. Perhaps you can merge as-is and later I / you / someone else can migrate this to use the Google tools. Otherwise, let me know and I will try to do it myself (but that might take a few days).

Cheers,
Gonzalo

--
Gonzalo Diethelm
gonzalo....@gmail.com

Zongwei Li

unread,
Oct 31, 2018, 6:39:45 PM10/31/18
to Gonzalo Diethelm, open-loca...@googlegroups.com
Thanks Gonzalo! I just merged your PR with a couple comments if you have some more time. Otherwise, I'll get to it eventually.

P.S. you had it right - Zongwei is my first name :)
Reply all
Reply to author
Forward
0 new messages