[PATCH] scsi: iscsi: register sysfs for workqueue iscsi_destroy

5 views
Skip to first unread message

Bob Liu

unread,
Jul 3, 2020, 1:16:57 AM7/3/20
to linux...@vger.kernel.org, open-...@googlegroups.com, martin....@oracle.com, ldu...@suse.com, cle...@redhat.com, michael....@oracle.com, Bob Liu
Register sysfs for workqueue iscsi_destroy, so that users can set cpu affinity
through "cpumask" for this workqueue to get better isolation in cloud
multi-tenant scenario.

This patch unfolded create_singlethread_workqueue(), added WQ_SYSFS and drop
__WQ_ORDERED_EXPLICIT since __WQ_ORDERED_EXPLICIT workqueue isn't allowed to
change "cpumask".

Suggested-by: Mike Christie <michael....@oracle.com>
Signed-off-by: Bob Liu <bob...@oracle.com>
---
drivers/scsi/scsi_transport_iscsi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 7ae5024..aa8d4a3 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -4766,7 +4766,9 @@ static __init int iscsi_transport_init(void)
goto release_nls;
}

- iscsi_destroy_workq = create_singlethread_workqueue("iscsi_destroy");
+ iscsi_destroy_workq = alloc_workqueue("%s",
+ WQ_SYSFS | __WQ_LEGACY | WQ_MEM_RECLAIM | WQ_UNBOUND,
+ 1, "iscsi_destroy");
if (!iscsi_destroy_workq) {
err = -ENOMEM;
goto destroy_wq;
--
2.9.5

Lee Duncan

unread,
Jul 3, 2020, 2:28:53 PM7/3/20
to Bob Liu, linux...@vger.kernel.org, open-...@googlegroups.com, martin....@oracle.com, cle...@redhat.com, michael....@oracle.com
Reviewed-by: Lee Duncan <ldu...@suse.com>

Mike Christie

unread,
Jul 4, 2020, 12:00:13 AM7/4/20
to Bob Liu, linux...@vger.kernel.org, open-...@googlegroups.com, martin....@oracle.com, ldu...@suse.com, cle...@redhat.com
Reviewed-by: Mike Christie <michael....@oracle.com>

Lee Duncan

unread,
Jul 4, 2020, 9:28:16 PM7/4/20
to Mike Christie, Bob Liu, linux...@vger.kernel.org, open-...@googlegroups.com, martin....@oracle.com, cle...@redhat.com
Reviewed-by: Lee Duncan <ldu...@suse.com>

Martin K. Petersen

unread,
Jul 8, 2020, 2:07:05 AM7/8/20
to linux...@vger.kernel.org, Bob Liu, Martin K . Petersen, michael....@oracle.com, ldu...@suse.com, open-...@googlegroups.com, cle...@redhat.com
On Fri, 3 Jul 2020 13:16:03 +0800, Bob Liu wrote:

> Register sysfs for workqueue iscsi_destroy, so that users can set cpu affinity
> through "cpumask" for this workqueue to get better isolation in cloud
> multi-tenant scenario.
>
> This patch unfolded create_singlethread_workqueue(), added WQ_SYSFS and drop
> __WQ_ORDERED_EXPLICIT since __WQ_ORDERED_EXPLICIT workqueue isn't allowed to
> change "cpumask".

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: iscsi: Register sysfs for workqueue iscsi_destroy
https://git.kernel.org/mkp/scsi/c/919a295abf96

--
Martin K. Petersen Oracle Linux Engineering
Reply all
Reply to author
Forward
0 new messages