[PATCH] iscsi-iname: fix iscsi-iname -p access NULL pointer without given IQN prefix

[Wu Bo]

From: Wu Bo <wub...@huawei.com>

iscsi-iname -p access NULL pointer without give IQN prefix.

# iscsi-iname -p
Segmentation fault

Signed-off-by: Wu Bo <wub...@huawei.com>
---
 utils/iscsi-iname.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/iscsi-iname.c b/utils/iscsi-iname.c
index da850dc..7df7bb0 100644
--- a/utils/iscsi-iname.c
+++ b/utils/iscsi-iname.c
@@ -69,7 +69,7 @@ main(int argc, char *argv[])
             exit(0);
         } else if ( strcmp(prefix, "-p") == 0 ) {
             prefix = argv[2];
-            if (strnlen(prefix, PREFIX_MAX_LEN + 1) > PREFIX_MAX_LEN) {
+            if (prefix && (strnlen(prefix, PREFIX_MAX_LEN + 1) >
PREFIX_MAX_LEN)) {
                 printf("Error: Prefix cannot exceed %d "
                        "characters.\n", PREFIX_MAX_LEN);
                 exit(1);
--
2.21.0

[The Lee-Man]

Thank you very much for this bug report and suggested patch, but I cleaned up the code and fixed it a little differently.