liuzhiqiang (I)
unread,Dec 9, 2019, 1:32:54 AM12/9/19Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to open-...@googlegroups.com, cle...@redhat.com, ha...@suse.de, eddi...@broadcom.com, Mingfangsen, gui...@huawei.com, wubo (T)
In find_vlan_dev func, socket should be checked before used.
Signed-off-by: Zhiqiang Liu <
liuzhi...@huawei.com>
---
usr/iscsi_net_util.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/usr/iscsi_net_util.c b/usr/iscsi_net_util.c
index b5a910f..c38456f 100644
--- a/usr/iscsi_net_util.c
+++ b/usr/iscsi_net_util.c
@@ -192,6 +192,10 @@ static char *find_vlan_dev(char *netdev, int vlan_id) {
int sockfd, i, rc;
sockfd = socket(AF_INET, SOCK_DGRAM, 0);
+ if (sockfd < 0) {
+ log_error("Could not open socket for ioctl.");
+ return NULL;
+ }
strlcpy(if_hwaddr.ifr_name, netdev, IFNAMSIZ);
ioctl(sockfd, SIOCGIFHWADDR, &if_hwaddr);
--
2.24.0.windows.2