Use Google Drive for checking permissions instead of e-mail address domain

[Tymoteusz Motylewski]

Hi
Thanks for publishing the app as opensource!
I'm evaluating to use the app in our organization. I've found one missing feature which prevents us from using the tool.
It's already reported under: https://github.com/nytimes/library/issues/55

It's about making Library use logged in user permissions to filter out documents. As right now everybody in the organization can see all the documents (from shared folder), not taking into account whether the user has permissions to see it or not.

I can assign a JS engineer on the topic, but in order to be effective I would like to discuss the architecture of the change with some of the maintainers.
I want to avoid situation where we put effort and it will not be integrated to the repo because we didn't have some important context.

Please let me know if you're interested in collaborating on this feature.

Thanks

Tymoteusz

P.S.
I wanted to join slack, but it seems it's only allowed to certain domains.

[Joe Germuska]

Tymoteusz:

 

People can request invitations to the News Nerdery slack by sending an email to newsn...@gmail.com – but I’ll invite you after I send this.

 

About your original question, I defer to the primary maintainers of Library.

 

As a workaround, would it work for your collaborators drafting the document to do so outside of the Library shared drive/folder, only moving it in once it is ready for anyone with access to the Library to see it?

 

Joe

 

 

--
Joe Germuska (he/his) • joege...@northwestern.edu • @JoeGermuska
Chief Nerd, Knight Lab • https://KnightLab.Northwestern.edu • @KnightLab

--
You received this message because you are subscribed to the Google Groups "NYT Library Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nyt-library-comm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/nyt-library-community/d76ef4bb-2753-4e88-ba1b-fcc39e63ad2e%40googlegroups.com.

[Tymoteusz Motylewski]

Hi Joe,

Thanks for the note about the slack channel.

My usecase with Library is to have a common place where all coworkers can go and see documents in a structured way.

Depending on the team you work in, you should have access only to certain documents/folders.

Some users should have access to documents from multiple teams.

The gdrive permissions are sufficient, just Library needs to respect them.

Cheers

Tymoteusz

To view this discussion on the web visit https://groups.google.com/d/msgid/nyt-library-community/4A7A71B4-7B63-4897-837C-9945F99B1CAF%40northwestern.edu.

[White, Isaac]

Hey Tymoteusz,

We've intended for Library to be open and collaborative from the beginning, which is why we haven't prioritized mirroring Google Drive permissions at the read level. 

You might be able to use the existing middleware customization pattern to add on even more granular read permissions based on Google Drive, if you wanted.

There's a bit of documentation on how to use custom middleware (and some examples) as part of our open source demo site.

Isaac

To view this discussion on the web visit https://groups.google.com/d/msgid/nyt-library-community/CABphOUdOuEk%3D2EuLd0-Ot07rUAfwhG%2BrpH6ONShv%3D5e4mpMRog%40mail.gmail.com.