Fontawesome incomplete?

[Jo_elektro]

Hi.

I have been dabbling with the font-awesome icons in Node-red dashboard and it seems that not the whole package of icons is available. For instance "fa-shower" works perfectly fine but "fa-lightbulb" doesn't and both are free to use. 
I looked into the folder "/home/pi/node_modules/font-awesome" and found that the current set is version V4.7.0.
How would I go about in updating the icon set to it's full and recent set?
I am currently running the Node-red version 0.17.5.

Greetings,

Jo

[Nick O'Leary]

Hi,

FontAwesome 5 has only just been released and we have not updated to it yet. FA5 completely changes the css markup structure so it is not a trivial upgrade to make. They do provide a shim layer that should allow the FA4 css to continue to work but we simply haven't had the time to look at it.

For now, your best bet is to stick with the FA 4.7 icons - https://fontawesome.com/v4.7.0/icons/ - including https://fontawesome.com/v4.7.0/icon/lightbulb-o/

If you really really want to upgrade you'll have to replace the files in node-red/public/vendor/font-awesome, ensure you use the v4 shim (https://fontawesome.com/how-to-use/upgrading-from-4) and fixup any filename changes. Oh, and as I said, we haven't tested the shim so no idea how feasible that is.

Nick

--
http://nodered.org
 
Join us on Slack to continue the conversation: http://nodered.org/slack
---
You received this message because you are subscribed to the Google Groups "Node-RED" group.
To unsubscribe from this group and stop receiving emails from it, send an email to node-red+unsubscribe@googlegroups.com.
To post to this group, send email to node...@googlegroups.com.
Visit this group at https://groups.google.com/group/node-red.
To view this discussion on the web, visit https://groups.google.com/d/msgid/node-red/0291eca8-97c5-4ee3-9704-ae981b004073%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Nick O'Leary]

Actually, having had a closer look, their shim is a javascript shim that dynamically replaces content in the page. I doubt that's going to work well at all with us - given we dynamically add/remove icons all the time as edit dialogs come and go.

So, I don't see us updating to FA5 any time soon - they have changed far too much for us to be able to upgrade without breaking the 1300+ nodes out there.

Nick

[Jo_elektro]

Thanks for taking the time to answer my question. Even if it is far more convoluted than I thought ;)

Greetings,

Jo



Op donderdag 15 februari 2018 11:02:11 UTC+1 schreef Nick O'Leary:

Actually, having had a closer look, their shim is a javascript shim that dynamically replaces content in the page. I doubt that's going to work well at all with us - given we dynamically add/remove icons all the time as edit dialogs come and go.

So, I don't see us updating to FA5 any time soon - they have changed far too much for us to be able to upgrade without breaking the 1300+ nodes out there.

Nick

On 15 February 2018 at 09:51, Nick O'Leary <nick....@gmail.com> wrote:

Hi,

FontAwesome 5 has only just been released and we have not updated to it yet. FA5 completely changes the css markup structure so it is not a trivial upgrade to make. They do provide a shim layer that should allow the FA4 css to continue to work but we simply haven't had the time to look at it.

For now, your best bet is to stick with the FA 4.7 icons - https://fontawesome.com/v4.7.0/icons/ - including https://fontawesome.com/v4.7.0/icon/lightbulb-o/

If you really really want to upgrade you'll have to replace the files in node-red/public/vendor/font-awesome, ensure you use the v4 shim (https://fontawesome.com/how-to-use/upgrading-from-4) and fixup any filename changes. Oh, and as I said, we haven't tested the shim so no idea how feasible that is.

Nick

On 15 February 2018 at 09:36, Jo_elektro <Jo_op...@hotmail.com> wrote:

Hi.

I have been dabbling with the font-awesome icons in Node-red dashboard and it seems that not the whole package of icons is available. For instance "fa-shower" works perfectly fine but "fa-lightbulb" doesn't and both are free to use. 
I looked into the folder "/home/pi/node_modules/font-awesome" and found that the current set is version V4.7.0.
How would I go about in updating the icon set to it's full and recent set?
I am currently running the Node-red version 0.17.5.

Greetings,

Jo

--
http://nodered.org
 
Join us on Slack to continue the conversation: http://nodered.org/slack
---
You received this message because you are subscribed to the Google Groups "Node-RED" group.

To unsubscribe from this group and stop receiving emails from it, send an email to node-red+u...@googlegroups.com.