The current master in GitHub has a text version of a symlink for several CSS files as their whole content

12 views
Skip to first unread message

Marcelo Huerta

unread,
Oct 14, 2020, 10:06:08 AM10/14/20
to nikola-discuss
The following files contain only a relative path to a non-existing directory in the repository:

nikola/data/themes/base/assets/css/baguetteBox.min.css
nikola/data/themes/bootblog4-jinja/assets/css/bootblog.css
nikola/data/themes/bootstrap4/assets/css/bootstrap.min.css
nikola/data/themes/bootstrap4-jinja/assets/css/bootstrap.min.css

Chris Warrick

unread,
Oct 14, 2020, 10:16:55 AM10/14/20
to Nikola—Discuss
All files work for me, the files they refer to exist. Are you on
Windows? If so, symlinks don’t work there by default, and Nikola will
fix them if you install. (On non-Windows platforms, those just appear
as standard symlinks in the filesystem.) You can also enable symlink
support and see if it changes anything:
https://github.com/git-for-windows/git/wiki/Symbolic-Links

--
Chris Warrick <https://chriswarrick.com/>
PGP: 5EAAEA16

Marcelo Huerta

unread,
Oct 14, 2020, 10:31:12 AM10/14/20
to nikola-discuss
I am, in fact, in Windows (Nikola v8.1.1, Python 3.8.5 (tags/v3.8.5:580fbb0, Jul 20 2020, 15:43:08) [MSC v.1926 32 bit (Intel)] on win32)

I used pip to install Nikola pointing to the latest master in GitHub:

Installing this way, or getting manually the ZIP file, I get the symlinks in the files and not the full content.

I tried cloning with Git enabling symlinks, to no avail.



Chris Warrick

unread,
Oct 14, 2020, 10:34:16 AM10/14/20
to Nikola—Discuss
Clone with git, cd into the repo and then run `pip install -U .` —
this should run our code in setup.py that fixes symlinks.

Marcelo Huerta

unread,
Oct 14, 2020, 10:43:38 AM10/14/20
to nikola-...@googlegroups.com
Chris Warrick escribió el 14/10/2020 a las 11:34:

> Clone with git, cd into the repo and then run `pip install -U .` —
> this should run our code in setup.py that fixes symlinks.

I did, even removing Nikola prior to the `pip install -U .`

That didn't work either.

--
o-=< Marcelo >=-o

Marcelo Huerta

unread,
Oct 14, 2020, 11:08:07 AM10/14/20
to nikola-discuss
Update: uninstalling Nikola and running `setup.py install` in the directory, works.

`pip install -U .` didn't run the conversion routine during install (as indicated by the fact that the repository was NOT marked as dirty after running it).

In any case, thank you for the leads towards a solution.

Chris Warrick

unread,
Oct 14, 2020, 2:30:54 PM10/14/20
to Nikola—Discuss
This pull request should fix pip, can you test it?

https://github.com/getnikola/nikola/pull/3468

Also, if you run `git config --global core.symlinks true` before
cloning, you should get Windows symlinks in the repo. This might
require Windows’ Developer Mode to be enabled to work.

Marcelo Huerta

unread,
Oct 14, 2020, 3:05:32 PM10/14/20
to nikola-...@googlegroups.com
Chris Warrick escribió el 14/10/2020 a las 15:30:

> This pull request should fix pip, can you test it?
>
> https://github.com/getnikola/nikola/pull/3468

I installed the windows-fix-symlinks-build branch with pip install directly
and it worked correctly.


--
o-=< Marcelo >=-o

Reply all
Reply to author
Forward
0 new messages