New Discussion: GitHub vs. Gerritt for Code Reviews

[Craig A]

Hi Everyone,

Now that we have moved our MOTECH code base to GitHub, I want to start the discussion of whether to move from Gerritt to GitHub for code reviews.

What features are available in Gerritt that are not available in GitHub for code reviews?

Sincerely,

Craig

[Robert LaRubbio]

I think with gerrit we have better security controls.  We can limit who can do a review and who can merge.  With github we don't have that ability.

We can lock down who can submit to the motech account, but then that would require anyone wanting to develop and issue a PR on motech to fork the repository.

--
You received this message because you are subscribed to the Google Groups "MOTECH Developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to motech-dev+...@googlegroups.com.
To post to this group, send email to motec...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/motech-dev/223ac9a1-f88c-472a-a866-63d1639073e1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Craig A]

Thanks Rob,

This seems to be the core issue. Should we retain the shared repository or adopt the fork and pull model? Here's a good link describing the differences between Gerrit and GitHub.

Also, it looks like the latest versions of Gerrit (2.10.3+) have the ability to add a Google and GitHub OAuth plugin for user authentication. This would require an upgrade and migration of users. 

Sincerely,

Craig

--
You received this message because you are subscribed to a topic in the Google Groups "MOTECH Developer" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/motech-dev/M6sGUKh9mwU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to motech-dev+...@googlegroups.com.

To post to this group, send email to motec...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/motech-dev/CA%2BhDffHFutCiusyuHunrP5tu8AGbJy4W1nJi-Kx9GP_ctQZFqw%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Craig Appl

Lead Technical Program Manager, Mobile Health Innovations

Grameen Foundation

2101 4th Ave | Suite 1550 | Seattle, WA 98121

Skype:craigappl

Facebook│Twitter│YouTube | www.motechsuite.org

Connecting the World's Poor to Their Potential

[Paweł Gesek]

I don't see a problem with using the fork model. I guess we can also give select teams rights to the repo and leave it to the team lead to enforce that the code review workflow is respected (we don't have hundreds of people actively developing, so that shouldn't really be an issue).

Gerrit has an interface a bit more geared towards code reviews so that's its plus. The plus side of Github is obviously a lower barrier of entry, than Gerrit. People now how to use GitHub, there is a lot of resources and documentation out there regarding GitHub usage.

I am personally leaning towards just using GitHub, the main befit I see however is that we get rid of one server to maintain, which means less headaches for us - no installing plugins, upgrading, solving issues with people not being able to connect, struggling with performance, etc. Also Gerrit is becoming really flaky lately - I solved memory issues with creating a swap partition on the instance, but now it seems its eating up the available processing power. If we stay with Gerrit we would have to upgrade the instance in my opinion.

If we switch to using GitHub, It will probably also be a plus that all of our projects would just be on Github, currently its all of our projects except the two main ones (which are technically on GitHub, but read only).

What do you think?

Regards,
Paweł

W dniu 2015-08-17 o 21:45, Craig A pisze:

To view this discussion on the web visit https://groups.google.com/d/msgid/motech-dev/CAOwqLVDe09vRH658n7fb9PGp7F1DLcvmqPePKde%3DdkEucaMYOw%40mail.gmail.com.

[Lauren Lavoie]

+1 for Pawel's points, especially re: ease of entry for community devs and removing the headache of managing the gerritt server.

---

From: Paweł Gesek
Sent: ‎8/‎20/‎2015 2:46 AM
To: motec...@googlegroups.com
Subject: Re: New Discussion: GitHub vs. Gerritt for Code Reviews

To view this discussion on the web visit https://groups.google.com/d/msgid/motech-dev/55D5A1E1.3070000%40soldevelo.com.

[Frank Huster]

Yep, ease of entry and all under one roof.

Let's do it!!!

To view this discussion on the web visit https://groups.google.com/d/msgid/motech-dev/55d5d9e0.2aff420a.96223.ffffbf75%40mx.google.com.

For more options, visit https://groups.google.com/d/optout.

--

Frank Huster

Mobile Health Innovations
Grameen Foundation

+1.206.325.6690 x201

[Koshal Thirumalai]

Sounds good to me. Are we thinking that we would do a fork per team/location?

To view this discussion on the web visit https://groups.google.com/d/msgid/motech-dev/CANgAW22giwJKa-y0DWkngDytMboO58GdMTjD7S_QmY7eONwRhw%40mail.gmail.com.

[Koshal Thirumalai]

I know we already made a decision to move, but this makes it even more awesome - 

https://github.com/blog/2051-protected-branches-and-required-status-checks