Bump plugin's major when upgrading required Maven version?
28 views
Skip to first unread message
Peter Palaga
Apr 22, 2019, 1:27:48 PM4/22/19
to mojoha...@googlegroups.com
Hi,
In license-maven-plugin, we are about to upgrade some maven core
dependencies. This will have the effect that the plugin won't run on
Maven 2.2+ anymore; it will require Maven 3.5.0+
Is this a reason to bump the major version on next release of the plugin?
The settings of the plugin, the behavior (except for fixing some bugs)
should stay fully backwards compatible.
Thanks,
-- Peter
In license-maven-plugin, we are about to upgrade some maven core
dependencies. This will have the effect that the plugin won't run on
Maven 2.2+ anymore; it will require Maven 3.5.0+
Is this a reason to bump the major version on next release of the plugin?
The settings of the plugin, the behavior (except for fixing some bugs)
should stay fully backwards compatible.
Thanks,
-- Peter
Mirko Friedenhagen
Apr 22, 2019, 1:58:31 PM4/22/19
to mojoha...@googlegroups.com
Hello,
I think bumping the major version could be a good way to signal that the Maven version has changed. (Although I do not think that anyone still using Maven 2 should expect new versions of plugins at all as it is deprecated for some years now).
Best Regards
Mirko Friedenhagen
—
Sent from my mobile
Am 22.04.19 um 19:27 schrieb Peter Palaga
> --
> You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
> To post to this group, send email to mojoha...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/68ac007a-9b8d-61f5-2590-d83780a66f08%40redhat.com.
> For more options, visit https://groups.google.com/d/optout.
I think bumping the major version could be a good way to signal that the Maven version has changed. (Although I do not think that anyone still using Maven 2 should expect new versions of plugins at all as it is deprecated for some years now).
Best Regards
Mirko Friedenhagen
—
Sent from my mobile
Am 22.04.19 um 19:27 schrieb Peter Palaga
> You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
> To post to this group, send email to mojoha...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/68ac007a-9b8d-61f5-2590-d83780a66f08%40redhat.com.
> For more options, visit https://groups.google.com/d/optout.
Anders Hammar
Apr 22, 2019, 2:55:24 PM4/22/19
to mojoha...@googlegroups.com
Maven 3.5.0+ is a fairly aggressive requirement. Is that really necessary?
/Anders (mobile)
Peter Palaga
Apr 22, 2019, 3:06:00 PM4/22/19
to mojoha...@googlegroups.com
On 22/04/2019 20:55, Anders Hammar wrote:
> Maven 3.5.0+ is a fairly aggressive requirement. Is that really necessary?
The initiator of the change says that we need a fine grained dependency
> Maven 3.5.0+ is a fairly aggressive requirement. Is that really necessary?
resolution that requires maven-resolver-provider, see
https://github.com/mojohaus/license-maven-plugin/pull/327
-- P
> <mailto:ppa...@redhat.com>> skrev:
>
> Hi,
>
> In license-maven-plugin, we are about to upgrade some maven core
> dependencies. This will have the effect that the plugin won't run on
> Maven 2.2+ anymore; it will require Maven 3.5.0+
>
> Is this a reason to bump the major version on next release of the
> plugin?
>
> The settings of the plugin, the behavior (except for fixing some bugs)
> should stay fully backwards compatible.
>
> Thanks,
>
> -- Peter
>
> --
> You received this message because you are subscribed to the Google
> Groups "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to mojohaus-dev...@googlegroups.com
> <mailto:mojohaus-dev%2Bunsu...@googlegroups.com>.
> Hi,
>
> In license-maven-plugin, we are about to upgrade some maven core
> dependencies. This will have the effect that the plugin won't run on
> Maven 2.2+ anymore; it will require Maven 3.5.0+
>
> Is this a reason to bump the major version on next release of the
> plugin?
>
> The settings of the plugin, the behavior (except for fixing some bugs)
> should stay fully backwards compatible.
>
> Thanks,
>
> -- Peter
>
> --
> You received this message because you are subscribed to the Google
> Groups "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to mojohaus-dev...@googlegroups.com
> To post to this group, send email to mojoha...@googlegroups.com
> <mailto:mojoha...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/mojohaus-dev/68ac007a-9b8d-61f5-2590-d83780a66f08%40redhat.com.
> For more options, visit https://groups.google.com/d/optout.
>
> https://groups.google.com/d/msgid/mojohaus-dev/68ac007a-9b8d-61f5-2590-d83780a66f08%40redhat.com.
> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google
> Groups "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to mojohaus-dev...@googlegroups.com
> <mailto:mojohaus-dev...@googlegroups.com>.
> You received this message because you are subscribed to the Google
> Groups "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to mojohaus-dev...@googlegroups.com
> To post to this group, send email to mojoha...@googlegroups.com
> <mailto:mojoha...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1s_exoLSun%3D1k_kAQCVTMCM-vB1076S9wFR%2Bx%3DeS5f0Mw%40mail.gmail.com
> <https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1s_exoLSun%3D1k_kAQCVTMCM-vB1076S9wFR%2Bx%3DeS5f0Mw%40mail.gmail.com?utm_medium=email&utm_source=footer>.
Mirko Friedenhagen
Apr 22, 2019, 3:07:05 PM4/22/19
to mojoha...@googlegroups.com
My stance here: unless we *test* plugins with all intermediate versions, requiring 3.5 is okish.
Best Regards
Mirko Friedenhagen
—
Sent from my mobile
Am 22.04.19 um 20:55 schrieb Anders Hammar
> To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1s_exoLSun%3D1k_kAQCVTMCM-vB1076S9wFR%2Bx%3DeS5f0Mw%40mail.gmail.com.
Best Regards
Mirko Friedenhagen
—
Sent from my mobile
Anders Hammar
Apr 25, 2019, 2:18:57 PM4/25/19
to mojoha...@googlegroups.com
Ok. I don't have enough knowledge in that area to say if that requirement is true or not. But as that library is a newer part of Maven I'm assuming it has been created for a reason.
Bumping the plugin's major version is appropriate when requiring Maven 3. That's how we have done it in the past with other plugins (at least the maven project plugins).
/Anders
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To post to this group, send email to mojoha...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/86559c54-5df3-7b22-fea2-a27934f24fda%40redhat.com.
Reply all
Reply to author
Forward
0 new messages