aspectj-maven-plugin status

100 views
Skip to first unread message

Alexander Bubenchikov

unread,
Jan 13, 2020, 10:41:33 AM1/13/20
to mojohaus-dev
Hi all

I Just wanted to now, what is the current status of aspectj-maven-plugin?

I see pull request  https://github.com/mojohaus/aspectj-maven-plugin/pull/45 to support java 11, it is marked as green, have more that 20 votes,  but not merged still.

Is there any issue in this PR, or  aspectj-maven-plugin is not supported now, or just nobody had enough time to look into it?

Thanks, Alexander

Anders Hammar

unread,
Jan 14, 2020, 2:21:34 AM1/14/20
to mojoha...@googlegroups.com
My guess is that nobody with interest in that plugin has had time to look into it. Some of our mojos are just maintained by a single developer and hence the activity is low. The aspectj mojo hasn't had a commit for almost two years now and seems to be one of those unfortunately.

/Anders

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/e1ba990a-21b5-433f-8858-494b4903696d%40googlegroups.com.

Phil Clay

unread,
Jan 16, 2020, 5:17:49 PM1/16/20
to mojohaus-dev
Is there any way for an interested person to become a maintainer of the aspectj-maven-plugin, since @davidkarlsen appears to no longer be maintaining it?

I'm assuming someone in the mojohaus github organization would have access to the aspectj-maven-plugin repository to grant someone access.


On Monday, January 13, 2020 at 11:21:34 PM UTC-8, Anders Hammar wrote:
My guess is that nobody with interest in that plugin has had time to look into it. Some of our mojos are just maintained by a single developer and hence the activity is low. The aspectj mojo hasn't had a commit for almost two years now and seems to be one of those unfortunately.

/Anders

On Mon, Jan 13, 2020 at 4:41 PM 'Alexander Bubenchikov' via mojohaus-dev <mojoha...@googlegroups.com> wrote:
Hi all

I Just wanted to now, what is the current status of aspectj-maven-plugin?

I see pull request  https://github.com/mojohaus/aspectj-maven-plugin/pull/45 to support java 11, it is marked as green, have more that 20 votes,  but not merged still.

Is there any issue in this PR, or  aspectj-maven-plugin is not supported now, or just nobody had enough time to look into it?

Thanks, Alexander

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojoha...@googlegroups.com.

Anders Hammar

unread,
Jan 18, 2020, 9:30:10 AM1/18/20
to mojoha...@googlegroups.com
That's absolutely possible. We don't have any strict guidelines for this process though.

But if you're interested you could state this together with some track record, like pull requests.

/Anders

To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/90736979-2f12-4c3c-a3c7-cfcc927ef2e0%40googlegroups.com.

Phil Clay

unread,
Jan 18, 2020, 12:14:00 PM1/18/20
to mojoha...@googlegroups.com
Thanks Anders

Yes, I'm interested.  At least temporarily, to get aspect-maven-plugin working with the latest releases of java, and building in ci (since the latest builds are failing on travis).  We'll see how that goes, and how much future time I have to dedicate to it.

Here is my github profile:  https://github.com/philsttr

I'm the active maintainer of https://github.com/logstash/logstash-logback-encoder, where I manage issues/PRs, publish releases, respond to stackoverflow questions, and actively develop.

I also occasionally contribute to other projects. Some recent PRs:

Let me know if there is anything else you need from me, and what the next steps are.

Phil


To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1vPSsfpUijM3a8SXFxKLdZxqkui3TW09R_WMBQzuJiiQg%40mail.gmail.com.

Anders Hammar

unread,
Jan 18, 2020, 12:21:22 PM1/18/20
to mojoha...@googlegroups.com
Ok, we're not really looking for "temporary" maintainers. In that case you should create PRs.

I file your pain though. I think the best approach is if you could provide a good PR and then ping us here to take a look. Hopefully david could spare a few cycles or someone else.

/Anders

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAKBvkK-2qpbPNSZ4gQR6kBooNkSuHXF-qvQa%3DBR22zN37a%3Dh%3DA%40mail.gmail.com.

Phil Clay

unread,
Jan 18, 2020, 12:45:28 PM1/18/20
to mojoha...@googlegroups.com
Ok.  There are several unmerged PRs addressing java compatibility that have been around for over a year without attention.  Unfortunately, I don't think me creating another PR is going to help.

This one, in particular, seems to provided everything needed:

A separate fork has even been published to maven central based on this change... com.nickwongdev:aspectj-maven-plugin.   My company has been using that fork for a while now, but we'd like to move back to the "official" plugin.

David has been unresponsive for over a year, so if anybody on this list could help, I think the community would appreciate it very much (See all the thumbs-up reactions on that PR).  No offense to David, but I think expecting David to continue maintenance at this point is not a good strategy.


To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAKDUN1v3QmNnSknGwZOWSEQ2BG81tZzM0yk5CaQpXrk2c4s1vg%40mail.gmail.com.

Nicholas Wong

unread,
Feb 10, 2020, 10:37:08 PM2/10/20
to mojohaus-dev
Hey Phil,

I'm actually talking to the AspectJ maintainer and David now about becoming a committer on the project, however, it seems to have already gotten one! Any chance you can fix the tests? Travis now hates JDK 8.

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojoha...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojoha...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojoha...@googlegroups.com.

Anders Hammar

unread,
Feb 11, 2020, 2:44:10 AM2/11/20
to mojoha...@googlegroups.com
On Tue, Feb 11, 2020 at 4:37 AM Nicholas Wong <nickw...@gmail.com> wrote:
I'm actually talking to the AspectJ maintainer and David now about becoming a committer on the project, however, it seems to have already gotten one! Any chance you can fix the tests? Travis now hates JDK 8. 

I think we should keep Java 8 support in our tests. It is possible to make Travis love Java 8 again by specifying a build image distro [1].


/Anders

 
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/1bfe041b-0600-4682-ade5-c168225ef761%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages