release please?

[Stephanie Wang]

Hi -- is it possible for us to do a release at your earliest convenience? We are waiting for a bug fix.

Thanks,

Stephanie

[Karl Heinz Marbaise]

Hi,

can you tell about which plugin we are talking?

Kind regards
Karl Heinz

[Stephanie Wang]

Hi Karl -- the flatten-maven-plugin please. We're waiting on https://github.com/mojohaus/flatten-maven-plugin/pull/155 to be rolled out specifically so we can continue adoption across GCP Java clients.

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/d19a435d-8227-4a72-a256-ce5151866a4do%40googlegroups.com.

--

Stephanie Wang stephwang@google.com Developer Programs Engineer BigQuery, Java

[Olivier Lamy]

I can look at this now

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAFzfq_69sJpGF_HYQSjmzL458Nmx5rRKvEBQ4kNdXXkHe8NzKw%40mail.gmail.com.

--

Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

[Stephanie Wang]

thank you!

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqRrdCnHO-rTqm3P8cHcD8puvEdS5uw7A-KYtAKmxYTrDw%40mail.gmail.com.

[Olivier Lamy]

not really dig into it but I get failures locally using maven 3.6.3

Using 

./mvnw clean verify -Prun-its

[ERROR] The following builds failed:

1672[ERROR] * no-overwrite-3.6.2-before/pom.xml

1673[ERROR] * no-overwrite-3.6.3-later/pom.xml

Log 

Running post-build script: /Users/olamy/dev/sources/open-sources/mojohaus/flatten-maven-plugin/target/it/no-overwrite-3.6.3-later/verify.groovy

java.lang.NumberFormatException: For input string: "Maven"

        at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)

        at java.base/java.lang.Integer.parseInt(Integer.java:652)

        at java.base/java.lang.Integer.valueOf(Integer.java:983)

And

Running post-build script: /Users/olamy/dev/sources/open-sources/mojohaus/flatten-maven-plugin/target/it/no-overwrite-3.6.2-before/verify.groovy

java.lang.NumberFormatException: For input string: "Maven"

        at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)

        at java.base/java.lang.Integer.parseInt(Integer.java:652)

        at java.base/java.lang.Integer.valueOf(Integer.java:983)

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAFzfq_7QJ3bLwyJ2j4MtdyZMJQpQ3NXb4eqNm6SU4%2BfHa%2B3KvA%40mail.gmail.com.

[Olivier Lamy]

definitely failing see gh actions here https://github.com/mojohaus/flatten-maven-plugin/actions/runs/130457854

[Nuoyu Yang]

I find where the problem is: I used bash command "./mvnw -v" to get the version of Maven in these two tests. It will return a string printed as this:

/home/yangnuoyu/maven-projects/flatten-maven-plugin
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/yangnuoyu/.m2/wrapper/dists/apache-maven-3.6.3-bin/lm9vem38rfmjij3jj0mk5bvnt/apache-maven-3.6.3
Java version: 1.8.0_251, vendor: Oracle Corporation, runtime: /usr/java/jdk1.8.0_251/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.19.98-08076-g24ab33fb8e14", arch: "amd64", family: "unix"

When I set a PR for these tests, the path in the first line was not part of the result so the version was the third element when I splitted it. For now, it seems like the path suddenly becomes a part of the string so the version becomes the fourth element after splitting. 

I will set another pull request soon to fix the problem. 

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqS%2BDXR%3D%2BwC4-orYS-Uzk11oru33f_A6tFdOEtWZ1b%2B9yQ%40mail.gmail.com.

[Nuoyu Yang]

I have fixed the problem and set a PR. Please check it out.

All the changes in this pr:

1. Fix the problem of parsing the Maven version by "./mvnw -v", the version may be the third or fourth word of the result. 
2. Fix the problem of parsing the Maven version in Windows. Instead of "./mvnw -v", we need to use "mvnw.cmd -v".
3. Fix the problem that the existing flattened pom is different from the pom we want to create since the line separator in Windows is "\r\n" instead of "\n"

[Nuoyu Yang]

Hi,

Is there any other problems which block the new version release of flatten-maven-plugin? 

Best,

Nuoyu

[Olivier Lamy]

I looked at my Friday morning trying to understand why site failed (bloody cobertura w\ java11 then GitHub changes failure) then it was Friday arvo very sunny and awesome waves so I have been to a surf!

I will do it this Saturday morning (waves are not really good :)) probably without the website 

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/a871aa0c-8d44-4431-8dbd-a338de3d070fn%40googlegroups.com.

[Stephanie Wang]

Thank you -- please keep us posted.

To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/CAPoyBqQE3yoTgFmiimRtyUO2WAZk%3DaXvM2HuHjrxh%2BMbg377kw%40mail.gmail.com.