Status of rpm-maven-plugin

[Erwin Bronkhorst]

Hi,

Tl;dr: What is the status of the rpm-maven-plugin and what are the chances of getting the project revived if I contribute?

More than 5 years ago, I opened a Pull Request on the rpm-maven-plugin in order to add a feature that I heavily use. One year later, after I processed the review comments, was the last activity on this PR.

The last real activity on the project was this Pull Request, which only updates a dependency for a test class that is not even used. Before that, a Pull Request that (in my honest opinion) broke more than it fixes was merged and that was all activity since 2018.

Long story short, I don't like the silence in the rpm-maven-plugin project and I am willing to invest some of my time to get it back on track. I actually already started this, by getting the project to build again on the latest mojo-parent and by using GitHub CI. You can find a preview of the changes here.

At this moment, I have a few questions:

- Does MojoHaus still see a future / added value for this plugin?

- How can I help in getting Pull Requests on this project being reviewed and merged? When the answer to my first question is 'yes', I am willing to go through the list of Pull Requests and Issues and see whether they are still relevant and if I can review/fix them.

- In order to get the build working again, I needed to disable the rpm-dirmode integration test. I am sure that the current implementation of the plugin is not correct, but I have difficulties in understanding the expected behaviour of the directoryIncluded and recurseDirectories parameters. Is there somebody available to discuss this with me? I can also start another conversation on this mailing list for that, if that is the preferred way.

If there is someone from MojoHaus willing to help me in getting changes accepted and merged, I want to do this proposal:

- I finish up my work on getting the project to build again using GitHub CI and the latest mojo-parent and open a Pull Request for that, which hopefully can be accepted and merged.

- I try to find a proper solution for issues #125 and #118, after consulting people that know more about this (help needed!), so the rpm-dirmode integration test can be enabled again.

- Maybe this would be a good moment for a new release.

- If all these steps are successful, I will go through the list of open issues and Pull Requests and process them accordingly.

- The code could use some cleanup after years of inactivity, so that would be the next step I can work on.

Kind regards,

Erwin Bronkhorst

[Benjamin Marwell]

Hi Erwin!

I certainly wouldn't mind, if this plugin is still used (even by just a few).

However, I think the focus should be diverted to updating the plugin to the Maven 3 API. The Maven 2 API will be defunct in Maven 4, Alpha versions already released.

To do this, the build chain must also be updated. It's been already done for other plugins, so this should no be too hard.

Does this work for you?

- Ben
   

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/73b19e1c-1047-42a9-b13a-d075eebf9851n%40googlegroups.com.

[Erwin Bronkhorst]

Hello Ben,

Thanks for your response! Actually, in the branch that I worked on, which updates to the latest mojo-parent, also contains the changes to Maven 3.6.3. Is this what you mean with 'updating the plugin to the Maven 3 API'?

Initially, I removed the mavenVersion property completely to inherit from the parent, but now I added it back explicitly in the pom again.

I opened a Pull Request (https://github.com/mojohaus/rpm-maven-plugin/pull/138) with these changes, which should enable further development.

Question: would the change to Maven 3 and Java 8 be a reason for a major version upgrade?

Kind regards,

Erwin

Op woensdag 19 juli 2023 om 07:30:46 UTC+2 schreef bmar...@apache.org: