Mojo Parent - properties

[Karl Heinz Marbaise]

Hi to all,

currently we have some properties in our mojo-parent which define maven-plugin versions.

I intend to remove them with the next release of the mojo-parent (51)

https://github.com/mojohaus/mojo-parent/issues/91

If there are no objections I will remove them on tuesday (May 26. 2020).

If you have objects please raise your hand.

Kind regards

Karl Heinz Marbaise

[mfried...@gmx.de]

Hello Karl Heinz,

I do not see the point, why properties are bad here. 

Overriding them on the command line is not the main 

benefit, but in a child project you may override 

versions with one line of code instead of at least 5 lines.

Say you have problems with latest surefire/failsafe.

Then it is 

<surefire.version>2.22.2</surefire.version> 

vs.

<pluginManagement>

<plugins>

<plugin>

<groupId>o.a.m.p</groupId>

<artifactId>maven-surefire-plugin</artifactId>

<version>2.22.2</version>

</plugin>

<plugin>

<groupId>o.a.m.</groupId>

<artifactId>maven-failsafe-plugin</artifactId>

<version>2.22.2</version>

</plugin>

</plugins>

</pluginManagement>

The latter are 14 lines of XML vs 1.

Best Regards
Mirko Friedenhagen
—
Sent from my mobile

Am 22.05.20 um 10:23 schrieb Karl Heinz Marbaise

--
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/64376aeb-418b-429c-98b1-8aae22963f13%40googlegroups.com.

[Stefan Seifert]

in my pov defining properties for versions of complex plugins that often have multiple plugins/dependencies defined in a single POM which all have to set to the same version is ok.
examples for such complex plugins are maven-release-plugin, maven-surefire/failsave-plugin

for other "simple" plugins it makes no sense, and it seems that the plugins listed by karl heinz fall into this latter category.

stefan

>Von: "Karl Heinz Marbaise" <mailto:goo...@soebes.de>
>Datum: 22. Mai 2020
>An: mojohaus-dev <mailto:mojoha...@googlegroups.com>

[mfried...@gmx.de]

Hello Stefan,

I agree the overhead is less for simple plugins but still 1 line vs 5 lines XML. And I think uniformity is a good thing as well. So either we use properties or do not for plugins. Or at least document and explain why we do stuff like we do it.

Best Regards
Mirko Friedenhagen
—
Sent from my mobile

Am 22.05.20 um 11:48 schrieb Stefan Seifert

> --
> You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/198ed6a426394f6fb7f2a3396ac019cb%40mailx01.intern.pro-vision.de.
>