FeatureEditor - Allow editing by fields

88 views
Skip to first unread message
Assigned to tobia....@geosolutionsgroup.com by lorenzo...@geosolutionsgroup.com

gaetan....@gmail.com

unread,
Jan 30, 2024, 9:47:00 AM1/30/24
to mapstore-developers
  • Description
According to the new Fields UI, it could be usefull to manage edition by fields.

This could be an answer to this use case :

As data manager (e.g natural area)
I need to use a configuration from fields UI
to allow some reporters to complete the land use value but prevent them to change assigned operator

  • Technical purpose

I propose to add a new allowEdit customEditorOptions property in FeatureEditor plugin config.
Next, we can retrieve this property in featureTypeToGridColumns to be able to identify disabled or editable columns :

https://github.com/geo2france/MapStore2/commit/f481e19af3fe0b9f4049ed74a9121f564d849452#diff-36ff7d01c9ef3f4b154a3f2f07497516c23bc79af7e3cae73eb855c017dc0e22R171

Here an example where only 3 fields are editable : 

allowEdit.gif

To finish, every Editors needs to be change to accept disabled property (this not works in current mapstore version) : 

https://github.com/geo2france/MapStore2/blob/f481e19af3fe0b9f4049ed74a9121f564d849452/web/client/components/data/featuregrid/editors/NumberEditor.jsx#L93


  • Configuration
For the previous example, here the config i will use with "allowEdit" property by field : 

configAllowEdit.png

  • Admin access
For this feature, ADMIN will always be able to change every fields and allowEdit property will be ignored every time an ADMIN user needs to change a fields.

=================

What do you thing about this new feature and technicall proposal ?

Thank you for your feedback. I will create a new pull request according to your comments.

Gaetan B

gaetan....@gmail.com

unread,
Mar 4, 2024, 10:03:05 AM3/4/24
to mapstore-developers
Hi,

As I'm waiting for a reply, should I reconsider this proposal ?
Thanks.

Gaëtan

Tobia Di Pisa

unread,
Mar 7, 2024, 4:06:20 AM3/7/24
to mapstore-...@googlegroups.com
Dear Gaetan,

I'm sorry for not keeping in touch with you sooner. That's really appreciated but we still have to check it unfortunately. We will try to check it to get back to you as soon as we can.

Best regards,
     Tobia Di Pisa

--
You received this message because you are subscribed to the Google Groups "mapstore-developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mapstore-develo...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/mapstore-developers/77af2b16-8ab2-496d-9b63-c90529092been%40googlegroups.com.


--


==
GeoServer Professional Services from the experts!

Visit http://bit.ly/gs-services-us for more information.
==
Dott. Ing. Tobia Di Pisa
Technical Lead / Project Manager


GeoSolutions Group
phone: +39 0584 962313

mobile: +39 340 1781783
fax:      +39 0584 1660272

https://www.geosolutionsgroup.com/
http://twitter.com/geosolutions_it
-------------------------------------------------------


Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

tobia.dipisa

unread,
Jun 24, 2024, 1:15:49 PM6/24/24
to mapstore-developers
Dear Gaetan,

I'm really sorry for the late feedback. 
I think this is connected with the other feature you are proposing on another thread of this ML. 
In addition I think both things should be handled a bit differently to be of general purpose.
In this specific case the option should be provided directly on top from the MS UI and this could be the Fields section of Layer Settings instead of the custom editors options which is covering only limited scenarios.
In any case this capability could be interesting and a PR for sure raised for introducing it in respect of the aforementioned design constraints.
Considering there are also other emails still involving the Attribute Table component where you are proposing additional updates, I think we can also schedule a call as soon as possible to better discuss together before you raise a PR.

Best Regards,
     Tobia Di Pisa
Reply all
Reply to author
Forward
0 new messages