Re: [PATCH] net: ethernet: stmmac: dwmac-sun8i: enable support of unicast filtering

20 views

Skip to first unread message

Sergei Shtylyov

unread,

May 13, 2019, 11:36:15 AM5/13/19

to Corentin Labbe, alexandr...@st.com, da...@davemloft.net, joa...@synopsys.com, maxime...@bootlin.com, peppe.c...@st.com, we...@csie.org, linux-...@vger.kernel.org, net...@vger.kernel.org, linux...@googlegroups.com

Hello!

On 05/13/2019 04:06 PM, Corentin Labbe wrote:

> When adding more MAC address to a dwmac-sun8i interface, the device goes

Addresses?

> directly in promiscuous mode.
> This is due to IFF_UNICAST_FLT missing flag.
>
> So since the hardware support unicast filtering, let's add IFF_UNICAST_FLT.
>
> Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
> Signed-off-by: Corentin Labbe <cla...@baylibre.com>
[...]

MBR, Sergei

David Miller

unread,

May 13, 2019, 1:00:31 PM5/13/19

to cla...@baylibre.com, alexandr...@st.com, joa...@synopsys.com, maxime...@bootlin.com, peppe.c...@st.com, we...@csie.org, linux-...@vger.kernel.org, net...@vger.kernel.org, linux...@googlegroups.com

From: Corentin Labbe <cla...@baylibre.com>
Date: Mon, 13 May 2019 13:06:39 +0000

> When adding more MAC address to a dwmac-sun8i interface, the device goes

> directly in promiscuous mode.
> This is due to IFF_UNICAST_FLT missing flag.
>
> So since the hardware support unicast filtering, let's add IFF_UNICAST_FLT.
>
> Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
> Signed-off-by: Corentin Labbe <cla...@baylibre.com>