Questions about sending patches (for e.g. drivers/media/platform/sunxi/sun4i-csi)

[Oleg Verych]

Hi!

1. In description of the linux-sunxi group there is an obsolete link:
>  And when sending patches try to follow Linux's Patch Submitting rules.

It seems that old link http://lxr.free-electrons.com/source/Documentation/SubmittingPatches

can be changed to either:
* https://linux-sunxi.org/Mailing_list#Submitting_patches

* or https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst

2. What repo is best to be the base for creating patches from?

* https://github.com/torvalds/linux
* https://github.com/linux-sunxi/linux-sunxi/tree/sunxi-next
or since I'm working with Olimex,
* https://github.com/OLIMEX/linux-olimex
* git://linuxtv.org/media_tree.git

3. Changes are related to drivers/media/platform/sunxi/sun4i-csi.

What to/cc addressed to include for such subsystem patches?
Is scripts/get_maintainer.pl under selected repo enough for that?

> ALLWINNER A10 CSI DRIVER
>   M:    Maxime Ripard <mri...@kernel.org>
>   L:    linux...@vger.kernel.org
>   S:    Maintained
>   T:    git git://linuxtv.org/media_tree.git
>   F:    Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml
>   F:    drivers/media/platform/sunxi/sun4i-csi/

Thanks.
___________

[Clément Péron]

Hi Oleg,

On Thu, 5 Jan 2023 at 15:09, Oleg Verych <ole...@gmail.com> wrote:

Hi!

1. In description of the linux-sunxi group there is an obsolete link:
>  And when sending patches try to follow Linux's Patch Submitting rules.

It seems that old link http://lxr.free-electrons.com/source/Documentation/SubmittingPatches

can be changed to either:
* https://linux-sunxi.org/Mailing_list#Submitting_patches

* or https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst

2. What repo is best to be the base for creating patches from?

* https://github.com/torvalds/linux
* https://github.com/linux-sunxi/linux-sunxi/tree/sunxi-next
or since I'm working with Olimex,
* https://github.com/OLIMEX/linux-olimex
* git://linuxtv.org/media_tree.git

In your case, if you try to patch "drivers/media/platform/sunxi/sun4i-csi".

It means your patches will go to the linux-media tree.

So you should rebase your patches on top of linux-media's next branch usually called "for-next" or "linux-next" or "xxx-next" but in this case it's "master".

You can also work on top linux-next which regularly merge all the next branches of all the different trees.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/

3. Changes are related to drivers/media/platform/sunxi/sun4i-csi.

What to/cc addressed to include for such subsystem patches?
Is scripts/get_maintainer.pl under selected repo enough for that?

> ALLWINNER A10 CSI DRIVER
>   M:    Maxime Ripard <mri...@kernel.org>
>   L:    linux...@vger.kernel.org
>   S:    Maintained
>   T:    git git://linuxtv.org/media_tree.git
>   F:    Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml
>   F:    drivers/media/platform/sunxi/sun4i-csi/

There is no hard rules (or I don't know it) usually I send the patches to: Maintainers and cc: ML

E.g taken from: https://unix.stackexchange.com/questions/453552/how-to-convert-scripts-get-maintainer-pl-output-as-input-to-mutt-or-git-send-ema

scripts/get_maintainer.pl 0001-my-patch.patch
and that gives output of format:

Josh Poimboeuf <jpoi...@redhat.com> (maintainer:LIVE PATCHING)
Jessica Yu <je...@kernel.org> (maintainer:LIVE PATCHING)
linux-...@vger.kernel.org (open list:BPF (Safe dynamic programs and tools))
live-p...@vger.kernel.org (open list:LIVE PATCHING)

 

Means I will do the following 

$> git send-email --annotate --to="Josh Poimboeuf <jpoi...@redhat.com>,Jessica Yu <je...@kernel.org>" --cc="linux-...@vger.kernel.org, live-p...@vger.kernel.org" HEAD^

 

Thanks.

Thanks for taking time to upstream your patches :)

BR,
Clement

 

___________

--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/47519564-b9b7-481b-aab2-adb83d6f46f6n%40googlegroups.com.

[Oleg Verych]

Clément, all,

On 1/5/23, Clément Péron <peron...@gmail.com> wrote:

> You can also work on top linux-next which regularly merge all the next
> branches of all the different trees.
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/

I've took Jan 4th https://github.com/torvalds/linux
I've also looked at https://git.linuxtv.org/media_tree.git/ and
others, where didn't noticed latest 'Linux 6.2-rc2' updates.

>> 3. Changes are related to drivers/media/platform/sunxi/sun4i-csi.
>> What to/cc addressed to include for such subsystem patches?
>> Is scripts/get_maintainer.pl under selected repo enough for that?
>

> There is no hard rules (or I don't know it) usually I send the patches to:
> Maintainers and cc: ML
>
> E.g taken from:
> https://unix.stackexchange.com/questions/453552/how-to-convert-scripts-get-maintainer-pl-output-as-input-to-mutt-or-git-send-ema
>
> scripts/get_maintainer.pl 0001-my-patch.patch
> and that gives output of format:
>
> Josh Poimboeuf <jpoi...@redhat.com> (maintainer:LIVE PATCHING)
> Jessica Yu <je...@kernel.org> (maintainer:LIVE PATCHING)
> linux-...@vger.kernel.org (open list:BPF (Safe dynamic programs and
> tools))
> live-p...@vger.kernel.org (open list:LIVE PATCHING)
>
> Means I will do the following
> $> git send-email --annotate --to="Josh Poimboeuf
> <jpoi...@redhat.com>,Jessica
> Yu <je...@kernel.org>" --cc="linux-...@vger.kernel.org,
> live-p...@vger.kernel.org" HEAD^

`get_maintainer.pl` had proposed me (among common) this MLs:

"open list:ALLWINNER A10 CSI DRIVER" <linux...@vger.kernel.org>
"open list:ARM/Allwinner sunXi SoC support" <linux...@lists.linux.dev>

where latter I thought is this one but it's not.

But it seems that real cooking happens there:
https://lore.kernel.org/linux-sunxi/
So patch is missed here but was sent to needed addresses:
https://lore.kernel.org/linux-sunxi/20230107083749...@gmail.com/T/#u

> Thanks for taking time to upstream your patches :)
> BR,
> Clement
>

Thanks!

--
sed 'sh && sed && node.js + olecom = happiness and mirth' << ''
-o--=O`C
#oo'L O
<___=E M