[PATCH net-next 1/5] net: stmmac: dwmac-sun8i: Return void from PHY unpower

16 views
Skip to first unread message

Samuel Holland

unread,
Jan 3, 2021, 6:25:51 AM1/3/21
to Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller, Jakub Kicinski, Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, Corentin Labbe, Ondrej Jirman, net...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, linux...@googlegroups.com, Samuel Holland
This is a deinitialization function that always returned zero, and that
return value was always ignored. Have it return void instead.

Signed-off-by: Samuel Holland <sam...@sholland.org>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index a5e0eff4a387..8e505019adf8 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -820,15 +820,14 @@ static int sun8i_dwmac_power_internal_phy(struct stmmac_priv *priv)
return 0;
}

-static int sun8i_dwmac_unpower_internal_phy(struct sunxi_priv_data *gmac)
+static void sun8i_dwmac_unpower_internal_phy(struct sunxi_priv_data *gmac)
{
if (!gmac->internal_phy_powered)
- return 0;
+ return;

clk_disable_unprepare(gmac->ephy_clk);
reset_control_assert(gmac->rst_ephy);
gmac->internal_phy_powered = false;
- return 0;
}

/* MDIO multiplexing switch function
--
2.26.2

Chen-Yu Tsai

unread,
Jan 6, 2021, 5:00:32 AM1/6/21
to Samuel Holland, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller, Jakub Kicinski, Maxime Ripard, Jernej Skrabec, Corentin Labbe, Ondrej Jirman, netdev, linux-arm-kernel, linux-kernel, linux-sunxi
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland <sam...@sholland.org> wrote:
>
> This is a deinitialization function that always returned zero, and that
> return value was always ignored. Have it return void instead.
>
> Signed-off-by: Samuel Holland <sam...@sholland.org>

Reviewed-by: Chen-Yu Tsai <we...@csie.org>
Reply all
Reply to author
Forward
0 new messages