[PATCH] media: sun4i-csi: Use CSI_INT_STA_REG name, fix typo in a comment

34 views
Skip to first unread message

Oleg Verych

unread,
Jan 9, 2023, 3:25:53 PM1/9/23
to open list:ARM/Allwinner sunXi SoC support, Oleg Verych, Maxime Ripard, Mauro Carvalho Chehab, open list:ALLWINNER A10 CSI DRIVER, linux-sunxi
---
drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c
index a3e826a75..95b5633b7 100644
--- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c
+++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c
@@ -245,7 +245,7 @@ static int sun4i_csi_start_streaming(struct vb2_queue *vq, unsigned int count)
* We need a scratch buffer in case where we'll not have any
* more buffer queued so that we don't error out. One of those
* cases is when you end up at the last frame to capture, you
- * don't havea any buffer queued any more, and yet it doesn't
+ * don't have any buffer queued any more, and yet it doesn't
* really matter since you'll never reach the next buffer.
*
* Since we support the multi-planar API, we need to have a
@@ -311,7 +311,7 @@ static int sun4i_csi_start_streaming(struct vb2_queue *vq, unsigned int count)
writel(CSI_BUF_CTRL_DBE, csi->regs + CSI_BUF_CTRL_REG);

/* Clear the pending interrupts */
- writel(CSI_INT_FRM_DONE, csi->regs + 0x34);
+ writel(CSI_INT_FRM_DONE, csi->regs + CSI_INT_STA_REG);

/* Enable frame done interrupt */
writel(CSI_INT_FRM_DONE, csi->regs + CSI_INT_EN_REG);
--
2.20.1

Oleg Verych

unread,
Jan 16, 2023, 6:04:30 PM1/16/23
to open list:ARM/Allwinner sunXi SoC support, Oleg Verych, Maxime Ripard, Mauro Carvalho Chehab, Sakari Ailus, open list:ALLWINNER A10 CSI DRIVER, linux-sunxi
Fix interrupt status register offset usage to be a defined name
CSI_INT_STA_REG (= 0x34) instead of a plain number.

Additionally fix a typo in a comment of the same file.

Signed-off-by: Oleg Verych <ole...@gmail.com>
Reply all
Reply to author
Forward
0 new messages