[PATCH] arm64: dts: allwinner: pinephone: Use generic sensor node names

19 views
Skip to first unread message

Samuel Holland

unread,
Nov 5, 2020, 10:21:51 PM11/5/20
to Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-ar...@lists.infradead.org, Rob Herring, devic...@vger.kernel.org, linux-...@vger.kernel.org, linux...@googlegroups.com, Samuel Holland, Maxime Ripard
Instead of duplicating part of the compatible string in the node name,
use generic names as recommended by (and listed in) section 2.2.2 of the
Devicetree Specification.

Suggested-by: Maxime Ripard <max...@cerno.tech>
Signed-off-by: Samuel Holland <sam...@sholland.org>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
index 2da69450eec1..2dfe9bae8c67 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
@@ -161,7 +161,7 @@ &i2c1 {
status = "okay";

/* Magnetometer */
- lis3mdl: lis3mdl@1e {
+ lis3mdl: magnetometer@1e {
compatible = "st,lis3mdl-magn";
reg = <0x1e>;
vdd-supply = <&reg_dldo1>;
@@ -169,7 +169,7 @@ lis3mdl: lis3mdl@1e {
};

/* Light/proximity sensor */
- stk3311@48 {
+ light-sensor@48 {
compatible = "sensortek,stk3311";
reg = <0x48>;
interrupt-parent = <&pio>;
@@ -179,7 +179,7 @@ stk3311@48 {
};

/* Accelerometer/gyroscope */
- mpu6050@68 {
+ accelerometer@68 {
compatible = "invensense,mpu6050";
reg = <0x68>;
interrupt-parent = <&pio>;
--
2.26.2

Maxime Ripard

unread,
Nov 6, 2020, 6:24:18 AM11/6/20
to Samuel Holland, Chen-Yu Tsai, Jernej Skrabec, linux-ar...@lists.infradead.org, Rob Herring, devic...@vger.kernel.org, linux-...@vger.kernel.org, linux...@googlegroups.com
On Thu, Nov 05, 2020 at 09:20:55PM -0600, Samuel Holland wrote:
> Instead of duplicating part of the compatible string in the node name,
> use generic names as recommended by (and listed in) section 2.2.2 of the
> Devicetree Specification.
>
> Suggested-by: Maxime Ripard <max...@cerno.tech>
> Signed-off-by: Samuel Holland <sam...@sholland.org>

Applied, thanks!
Maxime
signature.asc
Reply all
Reply to author
Forward
0 new messages