[PATCH] arm64: dts: sun50i-h5-orange-pi-pc2: Add CPUX voltage regulator

[Ondrej Jirman]

Orange Pi PC2 features sy8106a regulator just like Orange Pi PC.

Signed-off-by: Ondrej Jirman <meg...@megous.com>
---
.../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 29 +++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
index 70b5f09984218..5feedde95b5fc 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
@@ -85,6 +85,10 @@ reg_usb0_vbus: usb0-vbus {
};
};

+&cpu0 {
+ cpu-supply = <&reg_vdd_cpux>;
+};
+
&codec {
allwinner,audio-routing =
"Line Out", "LINEOUT",
@@ -180,6 +184,31 @@ flash@0 {
};
};

+&r_i2c {
+ status = "okay";
+
+ reg_vdd_cpux: regulator@65 {
+ compatible = "silergy,sy8106a";
+ reg = <0x65>;
+ regulator-name = "vdd-cpux";
+ silergy,fixed-microvolt = <1200000>;
+ /*
+ * The datasheet uses 1.1V as the minimum value of VDD-CPUX,
+ * however both the Armbian DVFS table and the official one
+ * have operating points with voltage under 1.1V, and both
+ * DVFS table are known to work properly at the lowest
+ * operating point.
+ *
+ * Use 1.0V as the minimum voltage instead.
+ */
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1400000>;
+ regulator-ramp-delay = <200>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+};
+
&uart0 {
pinctrl-names = "default";
pinctrl-0 = <&uart0_pa_pins>;
--
2.25.1

[Samuel Holland]

Hi Ondrej,

On 2/22/20 3:45 PM, Ondrej Jirman wrote:
> Orange Pi PC2 features sy8106a regulator just like Orange Pi PC.
>
> Signed-off-by: Ondrej Jirman <meg...@megous.com>
> ---
> .../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> index 70b5f09984218..5feedde95b5fc 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> @@ -85,6 +85,10 @@ reg_usb0_vbus: usb0-vbus {
> };
> };
>
> +&cpu0 {
> + cpu-supply = <&reg_vdd_cpux>;
> +};
> +

This should go alphabetically after "codec".

> &codec {
> allwinner,audio-routing =
> "Line Out", "LINEOUT",
> @@ -180,6 +184,31 @@ flash@0 {
> };
> };
>
> +&r_i2c {

This should go alphabetically before "spi0".

> + status = "okay";
> +
> + reg_vdd_cpux: regulator@65 {
> + compatible = "silergy,sy8106a";
> + reg = <0x65>;
> + regulator-name = "vdd-cpux";
> + silergy,fixed-microvolt = <1200000>;

The resistors in the datasheet (10k/11.8k) make this 1.1V.

> + /*
> + * The datasheet uses 1.1V as the minimum value of VDD-CPUX,
> + * however both the Armbian DVFS table and the official one
> + * have operating points with voltage under 1.1V, and both
> + * DVFS table are known to work properly at the lowest
> + * operating point.
> + *
> + * Use 1.0V as the minimum voltage instead.
> + */

The datasheet I have for H5 has "TBD" for the VDD-CPUX volatage range. I think
this comment only applies to H3 and is not necessary here.

> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1400000>;
> + regulator-ramp-delay = <200>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +};
> +
> &uart0 {
> pinctrl-names = "default";
> pinctrl-0 = <&uart0_pa_pins>;
>

Otherwise,
Reviewed-by: Samuel Holland <sam...@sholland.org>

Regards,
Samuel

[Ondřej Jirman]

Hi Samuel,

Ah, you're right. I didn't notice the fine print bellow:

https://megous.com/dl/tmp/e696b6042b80bf2e.png

only the big number above. Hehe.

> > + /*
> > + * The datasheet uses 1.1V as the minimum value of VDD-CPUX,
> > + * however both the Armbian DVFS table and the official one
> > + * have operating points with voltage under 1.1V, and both
> > + * DVFS table are known to work properly at the lowest
> > + * operating point.
> > + *
> > + * Use 1.0V as the minimum voltage instead.
> > + */
>
> The datasheet I have for H5 has "TBD" for the VDD-CPUX volatage range. I think
> this comment only applies to H3 and is not necessary here.

Ok.

> > + regulator-min-microvolt = <1000000>;
> > + regulator-max-microvolt = <1400000>;
> > + regulator-ramp-delay = <200>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +};
> > +
> > &uart0 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&uart0_pa_pins>;
> >
>
> Otherwise,
> Reviewed-by: Samuel Holland <sam...@sholland.org>

Thanks for the feedback.

regards,
o.

> Regards,
> Samuel

[Ondrej Jirman]

Orange Pi PC2 features sy8106a regulator just like Orange Pi PC.

Signed-off-by: Ondrej Jirman <meg...@megous.com>

Reviewed-by: Samuel Holland <sam...@sholland.org>
---
.../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
index 70b5f09984218..7b2572dc84857 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
@@ -93,6 +93,10 @@ &codec {
status = "okay";

};

+&cpu0 {
+ cpu-supply = <&reg_vdd_cpux>;
+};
+

&de {
status = "okay";
};
@@ -168,6 +172,22 @@ &ohci3 {
status = "okay";
};

+&r_i2c {

+ status = "okay";
+
+ reg_vdd_cpux: regulator@65 {
+ compatible = "silergy,sy8106a";
+ reg = <0x65>;
+ regulator-name = "vdd-cpux";

+ silergy,fixed-microvolt = <1100000>;

+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1400000>;
+ regulator-ramp-delay = <200>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+};
+

&spi0 {
status = "okay";

--
2.25.1

[Ondřej Jirman]

On Mon, Feb 24, 2020 at 10:27:04AM +0100, Maxime Ripard wrote:

> On Sun, Feb 23, 2020 at 11:40:19AM +0100, Ondrej Jirman wrote:
> > Orange Pi PC2 features sy8106a regulator just like Orange Pi PC.
> >
> > Signed-off-by: Ondrej Jirman <meg...@megous.com>
> > Reviewed-by: Samuel Holland <sam...@sholland.org>
> > ---
> > .../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
>

> Having a changelog would be great

> Looks like you fixed the issues reported by Samuel though. I've
> applied it.

Sorry, yes, I just did that. Re-ordering + removing a comment and changing the
fixed voltage.

Thank you,
o.

> Maxime