Refactoring of play_song

[Micah Wedemeyer]

In support of the socket interface I'd like to work on, I've been refactoring the play_song mega-method. My work so far is here: https://bitbucket.org/micahwedemeyer/lightshowpi/commits/9827e9659c91392f312eada9ca49e6bfb3ef25e9?at=pipes_and_filters

Basically, I want to make sure that people like the overall approach: Breaking things up into individual objects responsible for their little piece of functionality. The end goal is to build a pipes-and-filters system where the audio data is passed through various filters and the end output is the audio data along with the light matrix values.

It's been a lot of work so far, and there is a lot more work and cleanup to be done. I just don't want to do any more work on it if others don't support the direction I'm heading in.

Micah

[Todd Giles]

I'm definitely in favor of refactoring play_song (as my comments in the code suggest) --- and I understand the work required to do so and keep all existing functionality working, etc...  When / if I ever get (make) the time, my plan was to refactor nearly the entire file in a more object-oriented fashion --- I just don't know when that time will come at the moment.  So that said, I'm happy to review code changes and offer suggestions, etc... on the approach you are going down.

I know others have thoughts and ideas as well but likely also lack the time necessary to move forward very fast... let's see if others chime in on this one ;)

--
http://www.lightshowpi.com/
---
You received this message because you are subscribed to the Google Groups "LightShow Pi Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to lightshowpi-d...@googlegroups.com.
To post to this group, send email to lightsh...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/lightshowpi-dev/e344d862-5fa7-471d-b87f-27e03993353a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[chris usey]

Ditto what Todd said. Time is hard to come by lately.  Love the idea, will try to check out the code soon.

To view this discussion on the web visit https://groups.google.com/d/msgid/lightshowpi-dev/CAK2Uy1pHvfnAupAm78y4xuzk7K1a-KYqCYPoapDrk1NAFzb6Eg%40mail.gmail.com.