Cleaning-up lift-4.0

42 views
Skip to first unread message

François

unread,
Nov 11, 2024, 4:05:49 PM11/11/24
to Lift
Hello everyone,


I would love to see lift-4.0 go ahead, and so I opened 2 PR to help start with the subject:

- https://github.com/lift/framework/pull/2026: remove squery and reference to scala JSON combinator parser (it was deleted in newer version). The goal is to start cleaning-up dependencies with simple things before actually updating dependencies.

- https://github.com/lift/framework/pull/2027 : clean-up warnings. There a lot of warning, so I tried to correct all of them. Of course, that didn't work and it remains 2 categories (maybe bugs, deprecation change needing someone who knows what lift intents). I detailed all warning and their corrections in the PR description.

Tests pass, and Rudder (my lift application) seems to work fine with that - but it's a relatively simple app on the lift part, so I'm not sure it means a lot.

-- 
François ARMAND

Matt Farmer

unread,
Nov 11, 2024, 4:39:21 PM11/11/24
to lif...@googlegroups.com
Nice. I will have a look today!

On Nov 11, 2024, at 4:05 PM, François <fan...@gmail.com> wrote:

 Hello everyone,
--
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/liftweb/58cc9631-4ffe-42d4-80fd-91e616bc8e10%40gmail.com.

François

unread,
Nov 18, 2024, 5:05:27 AM11/18/24
to lif...@googlegroups.com
I addressed the different comments, could someone look at the PR again ?

Thanks !

Matt Farmer

unread,
Nov 20, 2024, 10:43:31 PM11/20/24
to lif...@googlegroups.com
Just approved and merged. Sorry it took so long - I'm still trying to
get back into sustainable OSS maintainer habits after having kids and
my youngest is three. lol.
> To view this discussion visit https://groups.google.com/d/msgid/liftweb/6dfdd375-d80b-49fc-8ee6-23b9b145b59c%40gmail.com.

François

unread,
Nov 21, 2024, 5:28:20 AM11/21/24
to lif...@googlegroups.com

Hello,


Hey, no problem :) It's also my part of the OSS thing to ping when I did my part of the work, there's no reason for having all the stress on the maintainer side.

Cheers !
-- 
François ARMAND
Reply all
Reply to author
Forward
0 new messages