Retire @bool recent_files_group_always?

42 views
Skip to first unread message

Edward K. Ream

unread,
Jun 12, 2019, 6:23:35 AM6/12/19
to leo-editor
Rev 3afff37 fixes #1188 by undoing a change related to #1121: unicode characters in command names.

This new fix is unlikely to cause problems.

However, I don't see the purpose of setting @bool recent_files_group_always to True.  It seems mostly to clutter the recent files menu.  Can anyone explain why this setting is useful?

Edward

Edward K. Ream

unread,
Jun 12, 2019, 12:16:58 PM6/12/19
to leo-editor
On Wednesday, June 12, 2019 at 5:23:35 AM UTC-5, Edward K. Ream wrote:

However, I don't see the purpose of setting @bool recent_files_group_always to True.  It seems mostly to clutter the recent files menu.  Can anyone explain why this setting is useful?

I have a half memory that this was supposed to group recent files by folder. This might be useful, but the present code doesn't do that.  I'll make a note in #1188.  Eventually, I should either retire @bool recent_files_group_always or make it work.

Edward

Rob

unread,
Jun 12, 2019, 4:02:06 PM6/12/19
to leo-e...@googlegroups.com
I use the setting because I have a number of .leo files with the same name, but different file paths. By grouping them, it reduces clutter and makes it easier to see which path version I'm opening.

HTH

It won't be the 'end of the world' to deprecate the option, but it is useful. Perhaps I'm the only one...

Rob...

Edward K. Ream

unread,
Jun 12, 2019, 5:20:51 PM6/12/19
to leo-editor


On Wed, Jun 12, 2019 at 3:02 PM Rob <lar...@gmail.com> wrote:
I use the setting because I have a number of .leo files withe the same name, but different file paths. By grouping them, it reduces clutter and makes it easier to see which path version I'm opening.

At last I understand.  If I understand correctly, this means that #1188 can be closed.

Edward

Rob

unread,
Jun 12, 2019, 9:43:40 PM6/12/19
to leo-editor
Yes, makes sense to me. Seems to work as expected now. Thanks for the fix!

Rob...

Edward K. Ream

unread,
Jun 13, 2019, 2:53:50 AM6/13/19
to leo-editor
On Wed, Jun 12, 2019 at 8:43 PM Rob <lar...@gmail.com> wrote:
Yes, makes sense to me. Seems to work as expected now. Thanks for the fix!

You're welcome.  Thanks for the confirmation.

Edward
Reply all
Reply to author
Forward
0 new messages