PR #2985 merged into devel. Please test!

[Edward K. Ream]

PR #2985 improves Leo's resilience to Python's black formatter. This PR contains significant changes to Leo's code that reads external files!

As discussed in the corresponding issue #2983, Leo has no real choice but to deal with black-formatted comments.

I don't expect problems:

- Various related unit tests have been strengthened.

- Imo, the new read code is significantly more robust than the old.

- The code passes "by hand" round-trip tests.

- I have been eating my own dog food for several days.

Nevertheless, any change to Leo's read code must be tested at length. Please test devel and report any problems immediately.

I'll delay the next release until at least early 2023 to ensure that this code is rock solid.

Edward

[Edward K. Ream]

On Wednesday, December 7, 2022 at 10:33:19 AM UTC-6 Edward K. Ream wrote:

PR #2985 improves Leo's resilience to Python's black formatter... I don't expect problems:

Issue #2996 reports a serious problem. PR #2985 is the likely culprit.

 Leo's read code over-indents comments that look like sentinels such as:

    # @todo fixme

Saving the file then over-indents the comment in original file. Leo has corrupted the file!

This issue must be fixed immediately.

Edward

[Edward K. Ream]

On Thursday, December 8, 2022 at 1:25:12 AM UTC-6 Edward K. Ream wrote:

Issue #2996 reports a serious problem.

PR #2997 fixes this problem. devel contains the fix.

Edward