Strangeness with tratment of node Icons - LeoJS and/or 'Classic'?

[jkn]

Has anything changed in the treatment of node Icons recently, please?

In the course of trying out LeoJS recently, and getting in a few knots re. 'file already open in another copy of Leo', I also hit an error where Leo 'classic' was failing to fully read a file. This seemed to be related to my occasional use of node icons.

AFAICT a node icon just gets turned into an "icons=long_hex_string" in the node entry:

<t tx="jkn.20231218110808.1" icons="5d71007d7101285804000000747970657102580400000066696c657103680358340000002f686f6d652f6a6b6e2f6c656f2d656469746f722f686561646c696e652d6974656d732f746869737765656b5f67726e2e706e677104580700000072656c50617468710558340000002f686f6d652f6a6b6e2f6c656f2d656469746f722f686561646c696e652d6974656d732f746869737765656b5f67726e2e706e677106580500000077686572657107580e0000006265666f7265486561646c696e6571085807000000796f666673657471094b005807000000786f6666736574710a4b02580400000078706164710b4b0158020000006f6e710c5805000000564e6f6465710d75612e">

### (body of node) ###

</t>

I'm unclear of the encoding, but FWIW I seemed to have recovered things, and allowed Leo Classic to open the files, by deleting the 'icons=' part in my file - luckily there were only a few of them.

Perhaps foolishly I did update my copy of Leo classic in the middle of all of my playing.

But I'm wondering if LeoJS somehow mangled something here, or if recent changes to Leo might have caused this.

I can try to recreate the problem and get a fuller error message if that would be useful. I thought I'd put this out in case this jogged any memories.

Thanks, Jon n

[Félix]

jkn

Can you give more info about those node icons? (custom attributes) Is the long hex string image file data, of just a path to a file on disk?

and share a sample .leo file that has only one or two nodes with icons ? (the smaller the better) I'll use it to make experiments and ensure that it gets read and written as-is to not corrupt any Leo files with custom attributes outside of regular 'UA's

I'll open an issue as soon as I can try it out.

Thanks again!

Félix

[jkn]

Hi Felix - yes, I will try to make a small file that demonstrates the issue. I think the long hex string must be a path to a file (encoded), but I am not sure of the mechanism.

IIRC LeoJS indicated this as some sort of note attribute (JSON?), but I need to re-run properly so as to give a more useful error report.

    Regards, Jon N