New Themes

[Chris George]

Two new themes are available in leo/themes: BreezeDark2 and Zepyhr Dark.

An update to Breeze Dark to accomodate dock widgets and refresh the look.

A new dark theme, Zephyr, based on Breeze Dark (that was a lot of work) with a new colour scheme and a few new wrinkles.

Feedback is required. Please let me know about undocumented anomalies via Issue #1219.

Chris

[Edward K. Ream]

On Thu, Jun 20, 2019 at 10:39 PM Chris George <techn...@gmail.com> wrote:

Two new themes are available in leo/themes: BreezeDark2 and Zepyhr Dark.

Many thanks for this work.  What is the status of #1218?

Edward

[Chris George]

I am stuck. I can't for the life of me figure out what the changes in the second commit have to do with it.

Chris

--
You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.
To post to this group, send email to leo-e...@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAMF8tS3-ZK2p9UQ_BtAS2-n5Xrp6WSWsd-osrq1YnezoZs9-Tg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Edward K. Ream]

On Fri, Jun 21, 2019 at 8:04 AM Chris George <techn...@gmail.com> wrote:

I am stuck. I can't for the life of me figure out what the changes in the second commit have to do with it.

Ok.  I'll look at it when I can.

Edward

[Matt Wilkie]

Thank you for tackling and sharing this Chris. Feedback to come when I finish catching up on the last month or so of activity that I've been apart from. A lot has happened!

-matt

[Matt Wilkie]

Thank you for tackling and sharing this Chris. Feedback to come when I finish catching up on the last month or so of activity that I've been apart from. A lot has happened!

Well I'm not caught up, but have started exploring the themes anyway ;-)

ZephyrDark on Linux Mint 18 laptop, resolution 1366x768

I like the overall colour tones. The contrast is high enough for my so-so eyes, but I'll have to wait until I've used for quite awhile to know for sure.

General

• Default font size much too large, everything is pretty squished. In screenshot below compare the window manager title with Leo's tab title.
• The pin/unpin and close control icons at each panels top right corner are just a jumble, not a recognisable picture or shape.
• the button row icons are 3 different shapes, background colours and fills, and sizes.
• The red "Leo Log Window" text is a bit hard to look at, I find my eyes kind of jittering over it.
• Menu drop downs: the dark background showing between each of the menu items makes little jail cells around everything, drawing my focus aware from the letters. Maybe the whitespace between items could be collapsed to zero, or just made much thinner. (I haven't figured out how to get a screenshot of an open menu yet. Hope my description makes sense.)
  

Outline:

• In outline tree's selected node there is a thin line black box within the overall "this is selected" highlight that over posts the headline text. This black line box is only visible when the tree has focus.
• The blue background of the selected node icon closed/expanded indicator doesn't fit with the theme colour pallette.

----

After an hour or so, I quite like it. It's my main theme on this machine for the time being.

-matt

[Chris George]

Thanks, Matt.

Now that docks have settled down I can work on theming them to be more consistent. I will poke at the rest and prepare an update.

Chris

--
You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/3b85f783-85d7-4155-9cb6-b63c2a541226%40googlegroups.com.

[Matt Wilkie]

A structural problem: theme font-size overrides myLeoSettings.leo, which I assume applies for all settings. I expect myLeoSettings to always have the last say.

Oh that's interesting, the `show-settings` command does not report base font settings, e.g. @font-size, @medium-font-size, etc. Neither does the report indicate which settings are set by a theme file.

-matt

[Edward K. Ream]

On Tue, Aug 20, 2019 at 8:32 AM Matt Wilkie <map...@gmail.com> wrote:

A structural problem: theme font-size overrides myLeoSettings.leo, which I assume applies for all settings. I expect myLeoSettings to always have the last say.

Hmm.  I'm not sure what I expect.

Edward

[Chris George]

It looks like the themes are supplanting font info but not anything else. For example, if I specify a setting in a theme file it gets overridden by myLeoSettings.leo which is the expected behaviour. Having the font info in a theme override that is inconsistent but could/should be offered as a choice. Or we should pick one way of doing it and eliminate the choice.

I have always thought it rather puzzling to have self-contained themes and then an entirely different way to set fonts.

My preference is to set everything related to UI in the theme.

I think that choice is Leonine. Whenever I propose a new way to do something I try to phrase it such that there should always be an @bool to offer choice so people can bend Leo to their own preferences. I believe that the default should be the theme as it gives new users one place to go to modify their UI experience.

I have totally ignored the entire "other way" as it may well be someone else's preference. But for new users, it is terribly confusing.

Chris

--

You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAMF8tS03aB3BDf%3DTDKei80NCXWrw61Tpq2bYN3UBQ_iPrn%3DV9Q%40mail.gmail.com.

[Terry Brown]

There is the Ctrl-+/- / Ctrl-mousewheel font zoom functionality to consider.  I don't think it was incompatible with themes, it just required specific naming conventions... maybe, I don't remember the details.  Anyway, just pointing out that factor's in there to be considered.

Cheers -Terry

To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CADWQas0RPe-Qsm3%2Ba1rYkb%3D_v496KFKZRXZkMnPd1-A%3DmPp2-g%40mail.gmail.com.

[Matt Wilkie]

I have always thought it rather puzzling to have self-contained themes and then an entirely different way to set fonts.

My preference is to set everything related to UI in the theme.

I agree, all UI elements should be in one place. However people shouldn't have to wade through tons of nodes to adjust basics like font-size and -family. A convention to always have these as cloned nodes at the top of the theme.leo would help.

For all-ui-in-theme approach the menu "Settings >> Edit Settings >> ***" would need to copy to the active theme instead of myLeoSettings. (Maybe not a significant barrier; I don't know.)

The cascade of "Settings >> My Settings >> This Leo File Settings" is a core principle and applies to just about everything. I think we can/should use this in UI as well. Theming confuses things because it's off to the side somewhere and isn't clear (to me) where it fits in the cascade.

Blue sky: I'd like to be able to run `show-settings` into a Leo panel, that has a filter category buttons plus a text field at top. From there I could 2x-click or [enter] on any given setting and be taken to the location where that is currently defined (LeoSettings, myLeoSettings, MyCoolTheme.leo, ThisLeofile.leo). At which point I could change as needed. If this place happens to be a System setting (not mysettings or local leo file) then my changes are saved/moved to the next level down. (Or answer a prompt which asks at which level to save the setting.)

-matt

[Matt Wilkie]

Blue sky: I'd like to be able to run `show-settings` into a Leo panel, that has a filter category buttons plus a text field at top. From there I could 2x-click or [enter] on any given setting and be taken to the location where that is currently defined (LeoSettings, myLeoSettings, MyCoolTheme.leo, ThisLeofile.leo). At which point I could change as needed. If this place happens to be a System setting (not mysettings or local leo file) then my changes are saved/moved to the next level down. (Or answer a prompt which asks at which level to save the setting.)

I decided this merited an enhancement issue entry: https://github.com/leo-editor/leo-editor/issues/1294

[Edward K. Ream]

On Tue, Aug 20, 2019 at 3:00 PM Matt Wilkie <map...@gmail.com> wrote:

Blue sky: I'd like to be able to run `show-settings` into a Leo panel, that has a filter category buttons plus a text field at top. From there I could 2x-click or [enter] on any given setting and be taken to the location where that is currently defined (LeoSettings, myLeoSettings, MyCoolTheme.leo, ThisLeofile.leo). At which point I could change as needed. If this place happens to be a System setting (not mysettings or local leo file) then my changes are saved/moved to the next level down. (Or answer a prompt which asks at which level to save the setting.)

Interesting ideas.  Not sure when, or if, I'll get to them.

Edward

[Chris George]

Matt,

What version of PyQt are you using?

With Python 3.6.8 and PyQt version 5.12.3, I do not see the headline lines or the light blue bits to the left of the selected node.

With Python 3.7.4 and PyQt 5.13.0, I do.

I will fiddle here to see why that might be.

Chris

[Chris George]

Python 3.6.8 and PyQt 5.13.0 display the problems.

Python 3.6.8 and PyQt 5.12.3 do not.

Sigh. Time to read the changelog.

Chris

[Chris George]

Curiouser and curiouser.

My distribution default is Python 3.6.8 and PyQt 5.12.3. This combination works just fine to run Leo and the two outline problems, headline box and blue background to the left of selected headlines, don't happen.

If I install PyQt5==5.12.2 to my user directory using pip3, Leo reports PyQt 5.12.3 and displays the problems.

So I fire up conda with Python 3.7.3 and PyQt version 5.9.6 and it displays the problems.

So at this point, the problem appears to be not with the version of PyQt but either the versions coming from PyPi (I tried several versions) or the fact that it is a virtual python environment.

I am not sure which would be worse.

I will stick with my distribution default for now and work on the rest of the problems before I come back to this. Perhaps someone on a different platform could do a little testing to see if we can narrow this down.

Chris

--

You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/f990d8d0-d5a1-4ab8-b9f4-2b39e392963b%40googlegroups.com.

[Chris George]

nb. The dock title bar icons work fine with Python 3.6.8 and PyQt 5.12.3.

Chris

[Chris George]

General

• Default font size much too large, everything is pretty squished. In screenshot below compare the window manager title with Leo's tab title.

I dropped it by 1px across the board and could probably go smaller. At 1920x1080 my eyes just aren't that good anymore. :-)

 

• The pin/unpin and close control icons at each panels top right corner are just a jumble, not a recognisable picture or shape.

This is related to the PyQt5 version issue which I will explore next. The solution so far is to not use a virtual python environment.

 

• the button row icons are 3 different shapes, background colours and fills, and sizes.

I don't use chapters so I had disabled them via @bool. Fixed.

 

• The red "Leo Log Window" text is a bit hard to look at, I find my eyes kind of jittering over it.

I brightened it a bit. Let me know what you think.

 

• Menu drop downs: the dark background showing between each of the menu items makes little jail cells around everything, drawing my focus aware from the letters. Maybe the whitespace between items could be collapsed to zero, or just made much thinner. (I haven't figured out how to get a screenshot of an open menu yet. Hope my description makes sense.)
  

I changed the background of the menu itself to the gradient and made the gap smaller and it seems to be a lot easier on the eyes.

Thanks for the input.

Chris

 

[Matt Wilkie]

• Default font size much too large, everything is pretty squished. In screenshot below compare the window manager title with Leo's tab title.

I dropped it by 1px across the board and could probably go smaller. At 1920x1080 my eyes just aren't that good anymore. :-)

I keep wishing there were a straightforward way to set Base Size in one place and then have everything else scale relative to that. Way back when CCS2 first came out I thought that was nailed with introduction of relative em and en's, let alone %. Sadly for (what a presume are real) reasons beyond my ken that has yet to materialize.

 

 

• the button row icons are 3 different shapes, background colours and fills, and sizes.

I don't use chapters so I had disabled them via @bool. Fixed.

Ditto. It's one of those widgets I've never known what were for but assumed must be good for something so left alone for some later exploration. I didn't know it could be disabled.

 

 

Thanks for the input.

 

You're welcome. I hope it didn't come across as too negative. It's so much easier to describe the funny or broken things ;-)

matt

[Chris George]

I have narrowed down the outline issue a baby step further.

After using venv, pyenv, and conda and having them all display the same problems I can pretty much say that it has nothing to do with the pyqt version and everything to do with virtual python environments.

When you did your testing were you using a virtual environment? If so, which one?

Chris

--

You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/aedbcadf-6da8-4ccb-a50a-ee8c959e425a%40googlegroups.com.

[Edward K. Ream]

On Tue, Aug 20, 2019 at 10:44 AM Chris George <techn...@gmail.com> wrote:

It looks like the themes are supplanting font info but not anything else.

I agree.  That's why I created #1298.

Edward

[Matt Wilkie]

After using venv, pyenv, and conda and having them all display the same problems I can pretty much say that it has nothing to do with the pyqt version and everything to do with virtual python environments.

When you did your testing were you using a virtual environment? If so, which one?

Conda (via miniconda3).It's very curious that it only occurs in virtuals, and that it is the same in all virtuals.

I can't test outside virtual because I can't run Leo on my Linux machine using the system python. Through some combination of using `sudo pip install ...` and `pip install --user` when I should have used the opposite the py env is messed up. I've spent hours trying to figure out how to revert to stock and gave up, running to the sanctuary of conda.

matt

[Chris George]

Heh.

Working with snap I have hosed my root filesystem twice with complete, fresh reinstalls.

So my default is pristine.

Chris

--

You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/ff7d1d4c-85e4-45ba-a2ee-aff043f5c811%40googlegroups.com.