PR #3678 merged into devel

22 views

Skip to first unread message

Edward K. Ream

unread,

Dec 8, 2023, 5:04:15 AM12/8/23

to leo-editor

Leo's devel branch now contains PR #3678. This PR improves the logic that reads external files and fixes bugs relating to the --blacken-sentinels command-line option.

All such changes are potentially dangerous. That's why this PR:

- makes minimal changes to existing code.

- improves the relevant unit tests.

Summary

The PR fixes significant bugs. Doing nothing was not an option. See the PR for details.

Despite my tests, the PR might have created new bugs. I merged this PR early so we could begin testing these changes immediately.

Please report any problems immediately.

Edward

Edward K. Ream

unread,

Dec 10, 2023, 11:13:43 AM12/10/23

to leo-editor

On Friday, December 8, 2023 at 4:04:15 AM UTC-6 Edward K. Ream wrote:

> Leo's devel branch now contains PR #3678.

> This PR improves the logic that reads external files and fixes bugs relating to the --blacken-sentinels command-line option.

Alas not. Issues #3702 and #3703 show that PR #3678 breaks Leo!

PR #3704 fixes both issues. This PR reverts Leo's read code while retaining recent minor (unrelated) improvements.

I am confident that the PR puts this episode behind us. The PR tells why in more detail.