Why is PR #3215 so large?

16 views
Skip to first unread message

Edward K. Ream

unread,
Jun 30, 2023, 2:10:24 PM6/30/23
to leo-editor

PR #3215 is indeed large and complicated. Here are the reasons why:


1. It had to be. Many files use unls, some in unexpected ways.


2. There was no reason to be overly fastidious. I knew PR #3215 would succeed. Adding other PRs would have slowed me down.


3. Some changes could not be made outside the PR because they relied on code defined only in the PR.


4. The PR's size doesn't matter:


- Leo's git-diff-pr command creates an outline that you can search using cff. Want to see a deleted kwarg? Just search the Leonine diffs.

- git bisect will find the root of any bug anywhere in Leo's history.

Summary


PR #3215 inherently affects many files.


I knew that PR #3215 would succeed. There was no need to fear impossible-to-correct bugs.


Edward

Reply all
Reply to author
Forward
0 new messages