PR 2863 completes annotation work for Leo 6.7.0

22 views

Skip to first unread message

Edward K. Ream

unread,

Sep 16, 2022, 7:34:38 AM9/16/22

to leo-editor

PR #2863 is a milestone: it correctly annotates all objects in the LeoFrame class.

The LeoFrame class (and subclasses) are the basis for Leo's gui-independent code. The new annotations are unions that describe each gui-dependent variant. Besides significantly strengthening mypy's type checking, these unions are superb documentation.

The present annotations are much better than expected. They are more than good enough for any foreseeable purpose. The new annotations should help Félix considerably.

Summary

It's time to declare that Leo's code is complete for the 6.7.0 release. Please report all bugs. There is plenty of time to fix them.

Edward

Edward K. Ream

unread,

Sep 16, 2022, 11:14:23 AM9/16/22

to leo-editor

On Friday, September 16, 2022 at 6:34:38 AM UTC-5 Edward K. Ream wrote:

PR #2863 is a milestone: it correctly annotates all objects in the LeoFrame class.

devel now contains PR #2864 which removes dozens of type:ignore suppressions. Removing these suppressions helps both the human reader and mypy. Imo, the few hours of work required was worthwhile.

The PR discusses the remaining type:ignore statements. For now, I'm content to leave them alone.

Summary

Aside from bugs, Leo's code base is complete. I plan no further big changes, either for Leo 6.7.0 or afterward.