Two more PRs merged into devel

93 views
Skip to first unread message

Edward K. Ream

unread,
Sep 18, 2022, 6:05:13 AM9/18/22
to leo-editor
devel now contains PR #2871 (icons) and PR #2873 (leoserver annotations).

Please continue your testing of devel. The icons issues was unexpectedly tricky, and deserves more testing.

We are still on track to release Leo 6.7.0 on Friday, September 30, but I'll be happy to push back that date if necessary.

Edward

Viktor Ransmayr

unread,
Sep 18, 2022, 3:47:48 PM9/18/22
to leo-editor
Hello Edward,

It looks like the 'test-all' command does no longer work ...

Does it mean that you already have removed all test-* commands as announced in

* Infor issue #2867 contains my development scripts

already?

If this is the case, then IMHO this would have deserved an individual msg to the users ;-)

With kind regards,

Viktor

Edward K. Ream

unread,
Sep 18, 2022, 3:53:55 PM9/18/22
to leo-editor
On Sun, Sep 18, 2022 at 2:47 PM Viktor Ransmayr wrote:

> It looks like the 'test-all' command does no longer work ...

Correct. I removed those commands recently.
> IMHO this would have deserved an individual msg to the users ;-)

Well, you have just created the message, hehe.

Edward

Thomas Passin

unread,
Sep 18, 2022, 3:57:54 PM9/18/22
to leo-editor
So what's the way for devs to test after making changes, if we don't have test-all?

Edward K. Ream

unread,
Sep 18, 2022, 4:00:13 PM9/18/22
to leo-editor
On Sun, Sep 18, 2022 at 2:57 PM Thomas Passin <tbp1...@gmail.com> wrote:
So what's the way for devs to test after making changes, if we don't have test-all?

Didn't I just write up info item #2867 ?

Imo, these scripts are more convenient to use because they run outside of Leo.

Edward

Thomas Passin

unread,
Sep 18, 2022, 5:00:41 PM9/18/22
to leo-editor
Just trying to make sure I understand correctly.

py -m unittest
Ran 941 tests in 12.162s
OK
py -m unittest leo.unittests.core.test_leoserver
Ran 3 tests in 2.017s
OK


Edward K. Ream

unread,
Sep 18, 2022, 7:35:05 PM9/18/22
to leo-editor
On Sun, Sep 18, 2022 at 4:00 PM Thomas Passin <tbp1...@gmail.com> wrote:
Just trying to make sure I understand correctly.

py -m unittest
Ran 941 tests in 12.162s
OK
py -m unittest leo.unittests.core.test_leoserver
Ran 3 tests in 2.017s
OK

Yes. I suggest your scripts cd to the leo-editor folder.

Edward

Thomas Passin

unread,
Sep 18, 2022, 10:02:50 PM9/18/22
to leo-editor
Of course; I just ran those by hand to try them out.

Viktor Ransmayr

unread,
Sep 19, 2022, 1:19:28 AM9/19/22
to leo-e...@googlegroups.com
Hello Edward,

Am So., 18. Sept. 2022 um 21:53 Uhr schrieb Edward K. Ream <edre...@gmail.com>:
On Sun, Sep 18, 2022 at 2:47 PM Viktor Ransmayr wrote:

> It looks like the 'test-all' command does no longer work ...

Correct. I removed those commands recently.

OK, I was only surprised, that the removal of ~ 50 (test-* & cover-*) commands did not warrant an own msg.

With kind regards,

Viktor

Edward K. Ream

unread,
Sep 19, 2022, 7:23:30 AM9/19/22
to leo-editor
On Mon, Sep 19, 2022 at 12:19 AM Viktor Ransmayr <viktor....@gmail.com> wrote:

OK, I was only surprised, that the removal of ~ 50 (test-* & cover-*) commands did not warrant an own msg.

Not announcing the change more clearly was an oversight on my part.

Edward

Félix

unread,
Oct 29, 2022, 5:06:38 PM10/29/22
to leo-editor
I was trying to find the way to test my modifications... (test-all has been removed as you all stated in this thread)

I found this thread and the commands given above 

py -m unittest 
and
py -m unittest leo.unittests.core.test_leoserver

which worked fine on my windows machine (Thanks Thomas!)

So i'm just wondering: Are the tests instructions/commands listed in leoPyRef.leo? or at https://www.leoeditor.com/leo_toc.html?  I could not find anything (although i admit i'm bad at searching and googling sometimes!) 

Félix

Félix

unread,
Jan 29, 2023, 9:09:28 PM1/29/23
to leo-editor
I was trying for a while to run the unit tests before making a small pull request to the Leo codebase... (it's been a while) and I Had to resort to searching the forums for this thread.

So I just thought I'd suggest to someone who may feel knowledgeable than me about python unit-testing systems to add a bit of info on the 'Testing' node in leoPyRef.leo.

My motivation is that I feel like simply mentioning: 

Run these tests using unittest or pytest from the command line.
See g.run_unit_tests and g.run_coverage_tests.

May not be enough for python/Leo newbies like me hehe.. :) 

Félix
Reply all
Reply to author
Forward
0 new messages