Please test the docks branch

32 views
Skip to first unread message

Edward K. Ream

unread,
Sep 6, 2019, 9:33:16 AM9/6/19
to leo-editor
The docks branch improves how Leo handles docks. This is #1318.

- Bug fix: The VR pane is moveable whenever --init-docks is in effect.
- The `@bool` @bool use-vr-dock  is no longer used.
- The VR pane is hidden for new windows.

The code changes are small, but this code must be considered experimental.

If you rearrange your docks, please test and report any problems.

Edward

Edward K. Ream

unread,
Sep 6, 2019, 10:28:33 AM9/6/19
to leo-editor
On Fri, Sep 6, 2019 at 8:33 AM Edward K. Ream <edre...@gmail.com> wrote:
The docks branch improves how Leo handles docks. This is #1318.

- Bug fix: The VR pane is moveable whenever --init-docks is in effect.
- The `@bool` @bool use-vr-dock  is no longer used.
- The VR pane is hidden for new windows.

The code changes are small, but this code must be considered experimental.

I have just merged docks into pyzo (not devel). All seems well.

Important: Leo will use the dock layout in the first loaded .leo file for new windows.  So if you don't want all of pyzo's docks in new windows, hide them in your first-loaded .leo file.

Edward

Brian Theado

unread,
Sep 6, 2019, 11:07:04 AM9/6/19
to leo-editor
I found some strange behavior when launching leo with a non-existent file on the command line. If I don't give any files on the command line or if I give the path to an existing file, then it is fine. But with the new file on command line, the tips windows appears and leo is still running, but there is no other window and I can only exit by hitting ctrl-c. This is on linux.

I used git bisect and found the bad behavior is introduced by commit 313f9e99af.

Let me know if you can't reproduce the issue and I can help more.

--
You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAMF8tS1FYozr4BENU%3Dp-N9nLjqhMTFwWTCp%2BCfzf%2BuQMQbLBeg%40mail.gmail.com.

Chris George

unread,
Sep 6, 2019, 11:56:11 AM9/6/19
to leo-e...@googlegroups.com
Leo 6.0-final, build 0aeeb6fdcb
2019-08-21 16:32:38 +0900
Python 3.7.4, PyQt version 5.13.0
linux

1. Delete cache.
2. Start Leo with only the one file from previous session.

I use @string central-dock-widget = body and @bool dockable-log-tabs = True.

My initial layout is the same dogs breakfast it has always been. :-)

Screenshot_20190906_082842.png


Once I get everything arranged how I like it it is the same as before.

Screenshot_20190906_085516.png



The vr pane has always been exactly the same as all the other docks for me. I can nest it, float it, move it wherever I like.

Chris


Chris

Edward K. Ream

unread,
Sep 6, 2019, 3:30:08 PM9/6/19
to leo-editor
On Fri, Sep 6, 2019 at 10:07 AM Brian Theado <brian....@gmail.com> wrote:

I found some strange behavior when launching leo with a non-existent file on the command line.

Thanks for this testing.  I'll fix it immediately.

Edward

Edward K. Ream

unread,
Sep 6, 2019, 3:31:30 PM9/6/19
to leo-editor
On Fri, Sep 6, 2019 at 10:56 AM Chris George <techn...@gmail.com> wrote:

Leo 6.0-final, build 0aeeb6fdcb

Huh?  The new code is in Leo 6.1-devel.

Edward

Chris George

unread,
Sep 6, 2019, 3:43:46 PM9/6/19
to leo-editor
Leo 6.1-devel, devel branch, build c46acee108
2019-09-06 07:32:05 -0500

Python 3.7.4, PyQt version 5.13.0
linux

That was so much fun to track down.

I am in the hospital still on my laptop. It was using a testbed I had installed via pip in pyenv.

Same result with the above.

Next up: a complete reinstall of my OS including a different distribution.

Back in an hour or so.

I love linux.

Chris

Chris George

unread,
Sep 6, 2019, 4:51:44 PM9/6/19
to leo-editor

Back in an hour or so.

I love linux.

Chris

And I am back.

What did I miss?

Fresh install of OS and all critical apps. I even took the time to do a backup of my home folder because it was getting a little crufty.

Chris
Reply all
Reply to author
Forward
0 new messages