#1342 ready for testing in the find-tab branch

Edward K. Ream

unread,

Sep 21, 2019, 6:32:37 PM9/21/19

to leo-editor

#1342 suggests replacing buttons in the Find Tab with labels. This works around intractable problems discussed in #1337.

The work is complete in the find-tab branch. Imo, using labels is plenty good enough.

As noted in #1342, you may want to add new style sheet entries to highlight these new labels.

I'd like your opinions before merging the find-tab branch into devel. Let me know what you think.

Edward

Chris George

unread,

Sep 21, 2019, 6:56:13 PM9/21/19

to leo-editor

Pretty straight forward.

You need default keybindings for Find All and Replace All.

Chris

--
You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/2b5df506-20d5-4e32-9bcd-c3d2a97b354f%40googlegroups.com.

Edward K. Ream

unread,

Sep 22, 2019, 5:19:43 AM9/22/19

to leo-editor

On Sat, Sep 21, 2019 at 5:56 PM Chris George <techn...@gmail.com> wrote:

Pretty straight forward.

You need default keybindings for Find All and Replace All.

The buttons will show bindings, if they exist. So you can define your own.

The alternative is to use <Alt-x>find-all or <Alt-x>replace-all.

Edward

Edward K. Ream

unread,

Sep 22, 2019, 6:46:02 AM9/22/19

to leo-editor

On Sunday, September 22, 2019 at 4:19:43 AM UTC-5, Edward K. Ream wrote:

You need default keybindings for Find All and Replace All.

The buttons will show bindings, if they exist. So you can define your own.

The alternative is to use <Alt-x>find-all or <Alt-x>replace-all.

Hmm. There is a better way. The buttons should show the proper spellings Alt-x command names.

Edward

Edward

Edward K. Ream

unread,

Sep 22, 2019, 7:06:08 AM9/22/19

to leo-editor

On Saturday, September 21, 2019 at 5:32:37 PM UTC-5, Edward K. Ream wrote:

#1342 suggests replacing buttons in the Find Tab with labels. This works around intractable problems discussed in #1337.

I have merged the find-tab branch into devel. The labels now give the full command names used in minibuffer. This is useful information, especially when there is no key binding for a particular command.

I'm happy with the result. Let me know if you aren't ;-)

Edward

Chris George

unread,

Oct 10, 2019, 2:18:57 PM10/10/19

to leo-editor

#1357

I cannot replace-all anymore. Everything else works as per the docs.

And I cannot use Alt-x if the cursor is in the "replace" text input field, which is very strange and apparently doesn't happen on Windows. (all I get is an x at the end of the replace string)

I even tried switching to '@bool minibuffer-find-mode = True' and following the docs to the letter. replace-all simply does not work for me at all.