Doh: PR's not required for our own branches

16 views
Skip to first unread message

Edward K. Ream

unread,
Oct 11, 2020, 2:53:34 PM10/11/20
to leo-editor
As I understand it, a PR is required only when attempting to merge a branch into someone else's branch. No need to create an issue and PR for branches that we own.

The recent fix in devel for findFirstValidAtLanguageDirective does not, imo, need the full issue/pr machinery.

Edward

Félix

unread,
Oct 11, 2020, 3:01:00 PM10/11/20
to leo-editor
Indeed, PR's are a useful way to 'package' the interactions and changes to a code base from someone else. It allows to see a condensed view of all that was changed, so it's easier to grasp the intent and methods used. (to eventually accept, or refuse changes until further modifications/fixes)

For personal code base management, not involving any third party, I just pull changes of a branch into some other branch as needed, and push back when it's done. 

--
Félix

Edward K. Ream

unread,
Oct 11, 2020, 3:04:28 PM10/11/20
to leo-editor
On Sun, Oct 11, 2020 at 2:01 PM Félix <felix...@gmail.com> wrote:

Indeed, PR's are a useful way to 'package' the interactions and changes to a code base from someone else. It allows to see a condensed view of all that was changed, so it's easier to grasp the intent and methods used. (to eventually accept, or refuse changes until further modifications/fixes)

For personal code base management, not involving any third party, I just pull changes of a branch into some other branch as needed, and push back when it's done. 

Thanks, Félix, for the confirmation of the abbreviated workflow. I was hoping you would comment.

Edward
Reply all
Reply to author
Forward
0 new messages