Last step before leointeg 1.0

[Félix]

Hey you guys, 

I just pushed 0.1.14 with a bunch of new features (Find-panel, import-file(s), and many more) along with bug fixes on the master branch!

One last step: I'm now going to finish re-writing/de-bugging the leoserver.py script to match Edward's architecture, structure and naming conventions. (And also to be completely client-agnostic) To then use it as the sever for leointeg directly from Leo's installation folder, instead of the original 'leobridgeserver.py' from leointeg. (which won't be needed anymore)

This is the last step before releasing the 1.0 version of leointeg, Which will be released as a 'real' extention. (which would then obviously be much more easy to install and use via the standard 'Extension panel' of vscode.)

Félix

Please dont hesitate if you have questions or comments!! 

[Viktor Ransmayr]

Hello Félix,

Are you aware of any obstacles, if I would like to try out 0.1.14 in a Fedora 33 - based Linux VM?

With kind regards,

Viktor

[Félix]

Hi Viktor! 

First of all, thank you for contributing to the leointeg project with your continued efforts in providing solutions to my questionings and also for testing installation and usage! Very much appreciated!!!  

 > Are you aware of any obstacles, if I would like to try out 0.1.14 in a Fedora 33 - based Linux VM? 

No i don't foresee any problems trying to test the vscode+leo+leointeg combination on a VM. I develop on both windows and ubuntu-linux machines, so i'm glad someone tries it on some other 'brand' of OSes.

In fact, its a great idea, as you can take 'snapshots' of the VM just before crucial dependency installations. (like just before installing Leo or vscode, etc.) to be able to 'rewind' to that state, once changes are made to the install procedures or the Leo/leointeg codebase, to re-test the installation and usage of those products, without having to start a new VM from scratch.

Many thanks again, and please don't hesitate to ask questions, report bugs, or ask for more features! :)

Félix

[Edward K. Ream]

On Thu, Jun 3, 2021 at 11:30 PM Félix <felix...@gmail.com> wrote:

Hey you guys, 

I just pushed 0.1.14 with a bunch of new features (Find-panel, import-file(s), and many more) along with bug fixes on the master branch!

Congratulations.  I'm just back from a short vacation. Playing with the master branch will be my top priority.

One last step: I'm now going to finish re-writing/de-bugging the leoserver.py script to match Edward's architecture, structure and naming conventions. (And also to be completely client-agnostic) To then use it as the sever for leointeg directly from Leo's installation folder, instead of the original 'leobridgeserver.py' from leointeg. (which won't be needed anymore)

I would rather you make leoserver.py work exactly the way you want, rather than the other way around. For example, you mentioned switching the "escape" convention so that "!" denotes a server method rather than a Leo method.

Are you planning to issue a PR against Leo?  That's what I expect :-)

This is the last step before releasing the 1.0 version of leointeg, Which will be released as a 'real' extention. (which would then obviously be much more easy to install and use via the standard 'Extension panel' of vscode.)

Just before I left on vacation I created Leo #1964: Prepare for leoInteg. This is just a placeholder for some of my thoughts.

To summarize: we want the launch of leoInteg to go as smoothly as possible. We want to help present Leonistas to become comfortable with vs-code, and leoInteg itself, so that soon after the launch we can all up-vote leoInteg.

In short, delaying the official launch of leoInteg by a week or two might be a good idea. What do you think? What are your plans?

Edward

[Félix]

>I would rather you make leoserver.py work exactly the way you want, rather than the other way around. For example, you mentioned switching the "escape" convention so that "!" denotes a server method rather than a Leo method.

Yes, I do change the implementation details to make it work properly, hehe ;)  but I keep the hierarchy and general code layout that you had put in place in leoserver.py.

 (with the log/verbose flags, error checking, etc. that was missing in my original implementation)

> In short, delaying the official launch of leoInteg by a week or two might be a good idea. What do you think? What are your plans?

Yes indeed, I don't want to rush anything, and I'm comfortable in releasing after june 21st / july if needs be to cleanup most apparent bugs and glitches. For now I'll concentrate in finishing the server rewrite and I'll make a more official post / list of things to do before release. 

Oh - while you're checking out the latest release ... the one issue that warrants the most pressing fix (for the sake of completeness) is https://github.com/boltex/leointeg/issues/140 perhaps that by being aware of it, you'll give me a suggestion to fix it easily, as you often do! :)

--

Félix

[Viktor Ransmayr]

Hello Félix,

Félix schrieb am Freitag, 4. Juni 2021 um 22:31:12 UTC+2:

 > Are you aware of any obstacles, if I would like to try out 0.1.14 in a Fedora 33 - based Linux VM? 

No i don't foresee any problems trying to test the vscode+leo+leointeg combination on a VM. I develop on both windows and ubuntu-linux machines, so i'm glad someone tries it on some other 'brand' of OSes.

In fact, its a great idea, as you can take 'snapshots' of the VM just before crucial dependency installations. (like just before installing Leo or vscode, etc.) to be able to 'rewind' to that state, once changes are made to the install procedures or the Leo/leointeg codebase, to re-test the installation and usage of those products, without having to start a new VM from scratch.

Thanks a lot for your feedback. - I started the work on setting up a VM for running VS Code in a Fedora environment.

I'll follow-up as soon as I've made reasonable progress - and/or - run into any LeoInteg specific issues ...

With kind regards,

Viktor

[Edward K. Ream]

On Sat, Jun 5, 2021 at 1:51 PM Félix <felix...@gmail.com> wrote:

Oh - while you're checking out the latest release ... the one issue that warrants the most pressing fix (for the sake of completeness) is https://github.com/boltex/leointeg/issues/140 perhaps that by being aware of it, you'll give me a suggestion to fix it easily, as you often do! :)

The relevant code is, I think, in the node `find.init_in_headline & helper` in leoFind.py.  This is tricky code, iirc, even though the code is just a few lines long.

I'm guessing that the question for you is how to simulate find.focus_in_tree. This is where I would start. Perhaps we should have a zoom discussion.

Edward

[Félix]

Tried your fix -> It works! 

So please go a head and merge it into devel & thank you for this quick fix & the server file path change  !! 

--

Félix

[Edward K. Ream]

On Sun, Jun 6, 2021 at 5:57 PM Félix <felix...@gmail.com> wrote:

Tried your fix -> It works! 

So please go a head and merge it into devel

Done.

& thank you for this quick fix & the server file path change  !! 

You're welcome.

Edward