PR #3215 is ready for review

unread,

Jun 28, 2023, 4:58:07 AM6/28/23

to leo-editor

PR #3215 creates optional unls based on gnxs.

I have been eating my own dog food for days without problems.

Please test the ekr-3181-mypy-links branch and report any problems.

Settings

leoSettings.leo contains three new settings related to unls:

@string unl-status-kind = gnx # use legacy for legacy unls.

@bool full-unl-paths = True

@data unl-path-prefixes

This last setting eliminates hard-coded hacks. The setting gives the absolute paths (on your machine) to the files given in unls.

As usual, you should override these settings in myLeoSettings.leo.

Edward

unread,

Jun 28, 2023, 5:14:53 AM6/28/23

to leo-editor

On Wednesday, June 28, 2023 at 3:58:07 AM UTC-5 Edward K. Ream wrote:

> PR #3215 creates optional unls based on gnxs.

I'll wait at least a week before merging this PR. There is plenty of time for comments and corrections.

Edward

unread,

Jun 28, 2023, 10:13:35 AM6/28/23

to leo-e...@googlegroups.com

On Wed, Jun 28, 2023 at 3:58 AM Edward K. Ream <edre...@gmail.com> wrote:

PR #3215 creates optional unls based on gnxs.

And now the PR is even more ready for review :-) Todays revs:

- Add two new helpers: g.findAnyUnl and g.isValidUnl.

- Using g.findAnyUnl in all plugins ensures that they support all forms of unls.

- Use g.isValidUnl to simplify bc.handleURL. More work is likely needed.

I plan no further code changes except for bookmarks.py.

I'll continue testing for at least several more days.

Edward

Reply all

Reply to author

Forward