Please test the "warnings" branch

52 views
Skip to first unread message

Edward K. Ream

unread,
Dec 20, 2019, 5:58:39 PM12/20/19
to leo-editor
This branch contains all work on #1454, remove all python -Wd warnings.

This issue has been closed.  However, more testing is needed, especially with --gui=console (cursesGui2.py).

Please report any problems here, not in the issue itself.

Edward

Matt Wilkie

unread,
Dec 20, 2019, 11:28:06 PM12/20/19
to leo-editor
Simple start, navigate tree, expand/contract nodes, edit, copy/paste works fine for me. However the body panel is vertically very narrow, only 6 lines, even though there is  room left for another dozen or so underneath the minibuffer (see attached).

Leo 6.2-b1-devel, warnings branch, build 36a71f9992 2019-12-20 17:45:47 -0500
Python 3.6.2, LeoGui: dummy version Windows 10 AMD64 (build 10.0.17134) SP0

-matt

leo-console-large-blank-space.png


Matt Wilkie

unread,
Dec 20, 2019, 11:35:00 PM12/20/19
to leo-editor
there's something a little funny with key handling on exit:
  • press Tab until [Quit Leo] is selected
  • press Enter
  • After a delay, perhaps 1s, the exit dialog is displayed, however cursor seems to somewhere behind as pressing arrow keys seems to change highlight or something in the background.
  • press Tab again >> now Yes/No is highlighted and cursor keys can be used to select
  • press Enter, Leo finishes closing and control is returned to the shell
-matt

Edward K. Ream

unread,
Dec 21, 2019, 4:48:54 AM12/21/19
to leo-editor
On Fri, Dec 20, 2019 at 11:28 PM Matt Wilkie <map...@gmail.com> wrote:
Simple start, navigate tree, expand/contract nodes, edit, copy/paste works fine for me. However the body panel is vertically very narrow, only 6 lines, even though there is  room left for another dozen or so underneath the minibuffer (see attached).

Thanks for this testing.

The only changes made in the "warnings" branch involve imports.  Is the behavior you describe different in the "devel" branch?

Edward

Edward K. Ream

unread,
Dec 21, 2019, 4:50:36 AM12/21/19
to leo-editor
On Fri, Dec 20, 2019 at 11:35 PM Matt Wilkie <map...@gmail.com> wrote:
there's something a little funny with key handling on exit:

I think this is the way the plugin always has worked.  It's not very smooth.

Again, I wouldn't think the revised imports could affect this kind of thing.

Edward

Matt Wilkie

unread,
Dec 21, 2019, 11:00:45 PM12/21/19
to leo-editor
I don't know if narrow body pane is new, probably not. I thought I'd mention it since console gui is top of mind at the moment and some of the code details will be be fresh.

-matt

Edward K. Ream

unread,
Dec 22, 2019, 5:52:11 AM12/22/19
to leo-editor
On Sat, Dec 21, 2019 at 11:00 PM Matt Wilkie <map...@gmail.com> wrote:
I don't know if narrow body pane is new, probably not. I thought I'd mention it since console gui is top of mind at the moment and some of the code details will be be fresh.

Imo, everything is as it was before.  I did fix some valid pylint complaints yesterday, but they should not affect the issues you raise.  We can both rest easy for now.

Edward
Reply all
Reply to author
Forward
0 new messages