Unit test failure on 'devel' branch

24 views
Skip to first unread message

Viktor Ransmayr

unread,
Jun 21, 2025, 12:48:54 PM6/21/25
to leo-editor
Hello Edward,

I updated my local 'devel' branch, ran the unit-tests & received the following traceback:

###

    ................s.........
    ======================================================================
    FAIL: test_g_relativeDirectory (leo.unittests.core.test_leoGlobals.TestGlobals.test_g_relativeDirectory)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/user/PyVE/GitHub/Leo/leo-editor/leo/unittests/core/test_leoGlobals.py", line 712, in test_g_relativeDirectory
        self.assertEqual(actual, expected)
        ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
    AssertionError: '../folder2/test3.py' != '..\\folder2\\test3.py'
    - ../folder2/test3.py
    ?   ^       ^
    + ..\folder2\test3.py
    ?   ^       ^


    ----------------------------------------------------------------------
    Ran 936 tests in 13.565s

    FAILED (failures=1, skipped=4)
    (Leo) [user@fedora-leo-study-vm leo-editor]$ 

###

With kind regards,

Viktor

Edward K. Ream

unread,
Jun 21, 2025, 2:12:24 PM6/21/25
to leo-editor
On Saturday, June 21, 2025 at 11:48:54 AM UTC-5 Viktor wrote:

I updated my local 'devel' branch, ran the unit-tests & received the following traceback:

Thanks for this report. I'll rethink the treatment of os.sep in the unit test. And test on Linux :-)

Edward

Edward K. Ream

unread,
Jun 23, 2025, 10:35:42 AM6/23/25
to leo-editor
PR #4374 (merged into devel) changes the unit test so it passes on both Linux and Window.

The new test is weaker than the old, but I think we can live with it until someone reports are problem with the tested code.

Edward

Viktor Ransmayr

unread,
Jun 23, 2025, 1:12:40 PM6/23/25
to leo-e...@googlegroups.com
Hello Edward,

Am Mo., 23. Juni 2025 um 16:35 Uhr schrieb Edward K. Ream <edre...@gmail.com>:
On Saturday, June 21, 2025 at 1:12:24 PM UTC-5 Edward K. Ream wrote:
On Saturday, June 21, 2025 at 11:48:54 AM UTC-5 Viktor wrote:

I updated my local 'devel' branch, ran the unit-tests & received the following traceback:

Thanks for this report. I'll rethink the treatment of os.sep in the unit test. And test on Linux :-)

PR #4374 (merged into devel) changes the unit test so it passes on both Linux and Window.

 Thanks a lot for fixing the issue !

With kind regards,

Viktor

Edward K. Ream

unread,
Jun 23, 2025, 2:16:44 PM6/23/25
to leo-e...@googlegroups.com
On Mon, Jun 23, 2025 at 12:12 PM Viktor Ransmayr <viktor....@gmail.com> wrote:

>> PR #4374 (merged into devel) changes the unit test so it passes on both Linux and Windows.
> Thanks a lot for fixing the issue !

You're welcome. Thanks again for your testing.

Edward
Reply all
Reply to author
Forward
0 new messages