The ekr-fullPath branch is code complete. Pls test

[Edward K. Ream]

Rev 99c1adc completes the programming work on #1914. See PR #1915 for a complete list of code-level changes.

This work undoes 30+ years of cruft involving evil keyword args and faux helpers in leoAtFile.py  This work is part of my legacy to future maintainers.

Some kwargs remain in leoAtFile.py:

- The event kwargs are necessary.

- Imo, the 'toString', 'fromString' and 'sentinels' are harmless. Removing them would be make-work.

- Other kwargs are more dubious, but I am not inclined to remove them now. These kwargs are unlikely to cause problems for future maintainers, which is what I care about.

Summary

Imo, the ekr-fullPath removes all problematic kwargs in leoAtFile.py. Happily, Leo's unit tests are strong in this area.  Nevertheless, subtle problems might remain.

Please report any problems immediately. I'll wait at least a week before merging ekr-fullPath into devel.

Some ugly kwargs remain, but perfectionism is not our friend. The new code is plenty good enough.

Edward

[Edward K. Ream]

On Monday, May 3, 2021 at 8:23:06 AM UTC-5 Edward K. Ream wrote:

> Subtle problems might remain.

Recent revs fix a recent blunder in at.scanAllDirectives. Please pull the latest version of the ekr-fullPath branch. Thanks.

Edward

[Edward K. Ream]

On Monday, May 3, 2021 at 8:23:06 AM UTC-5 Edward K. Ream wrote:

> Rev 99c1adc completes the programming work on #1914. See PR #1915 for a complete list of code-level changes.

...

> I'll wait at least a week before merging ekr-fullPath into devel.

In the absence of any bug reports I have merged the ekr-fullPath branch into devel. We may as well start testing the new code more widely. There is no going bad to the bad old code :-)

Edward