Improved links code now in both the devel and ekr-ann branches

[Edward K. Ream]

For reasons that I do not entirely understand, recent changes to put_html_links suddenly make it more robust than before. I have not seen failures recently. #2609 might be fixed!

I have just merged (by hand), the latest version of put_html_links from ekr-ann into devel, so everyone can test it.

I'll leave #2609 open for at least several more days,Please report any problems immediately.  Thanks.

Edward

[Viktor Ransmayr]

Hello Edward,

I did apply the latest changes to the 'devel' branch of Leo in a Fedora 34 VM running on Qubes-OS.

Executing the 'test-all' cmd the following test failure is reported:

###

...........s...........................................................................s.................................sss....................................................s.............................................................s..............................................................s....................s...........s.sss................................s............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
(python:1850): Gdk-CRITICAL **: 20:22:22.724: gdk_atom_intern: assertion 'atom_name != NULL' failed

(python:1850): Gdk-CRITICAL **: 20:22:22.724: gdk_atom_intern: assertion 'atom_name != NULL' failed
.F.........
======================================================================
FAIL: test_create_html_links (leo.unittests.test_gui.TestQtGui)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/user/PyVE/GitHub/Leo/leo-editor/leo/unittests/test_gui.py", line 127, in test_create_html_links
    self.assertEqual(result, expected, msg=repr(s))
AssertionError: False != True : 'leo\\unittest\\test_file.py:1326:8: W0101: Unreachable code (unreachable)\n'

----------------------------------------------------------------------
Ran 923 tests in 9.984s

FAILED (failures=1, skipped=14)

###

With kind regards,

Viktor

 

[Edward K. Ream]

On Wed, Apr 20, 2022 at 2:14 PM Viktor Ransmayr <viktor....@gmail.com> wrote:

>> I'll leave #2609 open for at least several more days. Please report any problems immediately.

I did apply the latest changes to the 'devel' branch of Leo in a Fedora 34 VM running on Qubes-OS.

Executing the 'test-all' cmd the following test failure is reported:

###

...........s...........................................................................s.................................sss....................................................s.............................................................s..............................................................s....................s...........s.sss................................s............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
(python:1850): Gdk-CRITICAL **: 20:22:22.724: gdk_atom_intern: assertion 'atom_name != NULL' failed

(python:1850): Gdk-CRITICAL **: 20:22:22.724: gdk_atom_intern: assertion 'atom_name != NULL' failed
.F.........
======================================================================
FAIL: test_create_html_links (leo.unittests.test_gui.TestQtGui)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/user/PyVE/GitHub/Leo/leo-editor/leo/unittests/test_gui.py", line 127, in test_create_html_links
    self.assertEqual(result, expected, msg=repr(s))
AssertionError: False != True : 'leo\\unittest\\test_file.py:1326:8: W0101: Unreachable code (unreachable)\n'

Thanks for this report. I'll be sure to test on Ubuntu.

Edward

[tbp1...@gmail.com]

ok on windows:

Ran 923 tests in 21.443s
OK (skipped=8)