All completed 6.6.2 work has been merged into devel

43 views
Skip to first unread message

Edward K. Ream

unread,
Apr 28, 2022, 6:11:29 AM4/28/22
to leo-editor
Leo's devel branch now contains all completed work for Leo 6.6.2, scheduled for Friday, May 27. The highlights of the new work are two mass updates to Leo's code base:

PR #2604: Annotate important files.
PR #2622: Remove hanging indents using cvt-comments script.

These mass updates are likely to be the last. Or so I hope :-)

Please test devel and report any problems.  Thanks.

Edward

Viktor Ransmayr

unread,
Apr 29, 2022, 12:35:27 AM4/29/22
to leo-editor
Hello Edward,

I did again apply the latest changes to the 'devel' branch of Leo in a Fedora 34 VM running on Qubes-OS.

Executing the 'test-all' cmd the following test failure is still reported:

###

...........s...........................................................................s.................................sss....................................................s.............................................................s....................................................................................................................................s.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................F.........
======================================================================
FAIL: test_create_html_links (leo.unittests.test_gui.TestQtGui)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/user/PyVE/GitHub/Leo/leo-editor/leo/unittests/test_gui.py", line 127, in test_create_html_links
    self.assertEqual(result, expected, msg=repr(s))
AssertionError: False != True : 'leo\\unittest\\test_file.py:1326:8: W0101: Unreachable code (unreachable)\n'

----------------------------------------------------------------------
Ran 923 tests in 9.156s

FAILED (failures=1, skipped=8)

###

With kind regards,

Viktor

Edward K. Ream

unread,
Apr 29, 2022, 5:57:24 AM4/29/22
to leo-editor
On Thu, Apr 28, 2022 at 11:35 PM Viktor Ransmayr

I did again apply the latest changes to the 'devel' branch of Leo in a Fedora 34 VM running on Qubes-OS.

Executing the 'test-all' cmd the following test failure is still reported:
[snip]

======================================================================
FAIL: test_create_html_links (leo.unittests.test_gui.TestQtGui)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/user/PyVE/GitHub/Leo/leo-editor/leo/unittests/test_gui.py", line 127, in test_create_html_links
    self.assertEqual(result, expected, msg=repr(s))
AssertionError: False != True : 'leo\\unittest\\test_file.py:1326:8: W0101: Unreachable code (unreachable)\n'

Thanks for this report. I'll look into it.

Edward

Edward K. Ream

unread,
Apr 29, 2022, 9:23:56 AM4/29/22
to leo-editor
On Thu, Apr 28, 2022 at 11:35 PM Viktor Ransmayr wrote:

I did again apply the latest changes to the 'devel' branch of Leo in a Fedora 34 VM running on Qubes-OS.

Executing the 'test-all' cmd the following test failure is still reported:

 Fixed in devel at rev b82ddf8. The failure was in the unit test itself, not the code under test.

devs take note

g.run_unit_tests now runs unit tests using python3 -m unittest rather than python -m unittest.

The difference is particularly important on Linux because creating an alias from python to pyhthon3 is a good way of making Linux unusable, as I have found out several times! So to run Leo's unit tests on python devs must create a python3 alias if it does not already exist (but it probably does exist :-)

Edward

tbp1...@gmail.com

unread,
Apr 29, 2022, 9:46:54 AM4/29/22
to leo-editor
there is usually a more specific alias too, like "python3.8".  I have one VM that has both "python3.6" and "python3.8".
plain "python" still usually means python 2.x.

Viktor Ransmayr

unread,
Apr 29, 2022, 3:44:34 PM4/29/22
to leo-editor
Hello Edward,

Edward K. Ream schrieb am Freitag, 29. April 2022 um 15:23:56 UTC+2:
On Thu, Apr 28, 2022 at 11:35 PM Viktor Ransmayr wrote:

I did again apply the latest changes to the 'devel' branch of Leo in a Fedora 34 VM running on Qubes-OS.

Executing the 'test-all' cmd the following test failure is still reported:

 Fixed in devel at rev b82ddf8. The failure was in the unit test itself, not the code under test.

Running the 'test-all' cmd on this revision passes  w/o failures in a Fedora 34 - as well as - a Debian 11 VM running on Qubes-OS.

Thanks a lot for your quick response!

With kind regards,

Viktor

Edward K. Ream

unread,
Apr 29, 2022, 3:50:08 PM4/29/22
to leo-editor
On Fri, Apr 29, 2022 at 2:44 PM Viktor Ransmayr  wrote:

>> Fixed in devel at rev b82ddf8. The failure was in the unit test itself, not the code under test.

Running the 'test-all' cmd on this revision passes  w/o failures in a Fedora 34 - as well as - a Debian 11 VM running on Qubes-OS.

Thanks a lot for your quick response!

You're welcome. Thanks for your continued testing.

Edward

Félix

unread,
May 10, 2022, 12:04:45 AM5/10/22
to leo-editor
I'll try to add a couple new features to the server in the next week or two. (if it's ok) 

Félix

Edward K. Ream

unread,
May 10, 2022, 7:25:31 AM5/10/22
to leo-editor
On Mon, May 9, 2022 at 11:04 PM Félix <felix...@gmail.com> wrote:
I'll try to add a couple new features to the server in the next week or two. (if it's ok) 

Of course it's ok. This kind of thing is the reason for Leo's next release.

Edward

Félix

On Friday, April 29, 2022 at 3:50:08 PM UTC-4 Edward K. Ream wrote:
On Fri, Apr 29, 2022 at 2:44 PM Viktor Ransmayr  wrote:

>> Fixed in devel at rev b82ddf8. The failure was in the unit test itself, not the code under test.

Running the 'test-all' cmd on this revision passes  w/o failures in a Fedora 34 - as well as - a Debian 11 VM running on Qubes-OS.

Thanks a lot for your quick response!

You're welcome. Thanks for your continued testing.

Edward

--
You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/2273e5e0-ed6d-436e-8efc-d00993032ec4n%40googlegroups.com.


--
-----------------------------------------------------------------
Edward K. Ream: edre...@gmail.com
An old man, crazy about computer programming.
-----------------------------------------------------------------
Reply all
Reply to author
Forward
0 new messages