PR #3224: mod_autosave is ready for review

Edward K. Ream

unread,

Mar 27, 2023, 7:33:12 AM3/27/23

to leo-editor

PR #3224 contains proposed changed to the mod_autosave plugin.

See the PR for a summary of the improvements.

Please try the code and report your experiences. Thanks.

Edward

Edward K. Ream

unread,

Mar 27, 2023, 7:12:51 PM3/27/23

to leo-editor

On Monday, March 27, 2023 at 6:33:12 AM UTC-5 Edward K. Ream wrote:

PR #3224 contains proposed changed to the mod_autosave plugin.

The new code has been merged into devel. This PR amounts to a complete rewrite of the plugin:

- The plugin saves outlines to .bak files, thereby avoiding any undo issues.

- The plugin does not change any part of Leo's UI, thereby avoiding any impact on normal editing.

- A new setting controls whether the plugin writes log messages to the console.

The plugin never writes messages to Leo's log pane.

This plugin is useful enough that I have enabled it (for the first time). I'll let you know if I find any problems.

Edward

Edward K. Ream

unread,

Mar 27, 2023, 8:10:02 PM3/27/23

to leo-editor

On Monday, March 27, 2023 at 6:12:51 PM UTC-5 Edward K. Ream wrote:

> [The mod_autosave] plugin is useful enough that I have enabled it (for the first time). I'll let you know if I find any problems.

Recent commits fixed a crash involving queued messages in verbose mode and then suppressed all such queued messages entirely. Such messages quickly become intolerably annoying.

I am beginning to agree with Thomas that verbose mode itself is annoying :-) Happily, verbose mode is off by default.

Edward

Thomas Passin

unread,

Mar 28, 2023, 9:06:52 AM3/28/23

to leo-editor

When verbose mode is on, then when autosave happens the Log pane switches to the Log tab to write the message. This can be really annoying if you are working in another tab at the time. Another reason for the verbose mode setting.

Edward K. Ream

unread,

Mar 28, 2023, 10:31:21 AM3/28/23

to leo-e...@googlegroups.com

On Tue, Mar 28, 2023 at 8:06 AM Thomas Passin <tbp1...@gmail.com> wrote:

When verbose mode is on, then when autosave happens the Log pane switches to the Log tab to write the message. This can be really annoying if you are working in another tab at the time. Another reason for the verbose mode setting.