PR 2393 creates leo.plugins.remove_duplicate_pictures

[Edward K. Ream]

PR #2393 has been merged into devel. This PR adds a program (nominally a plugin) that removes duplicate pictures from a directory and its subdirectories. There is no need ever to enable this plugin.

To execute:  python -m leo.plugins.remove_duplicate_pictures <args>

The -h argument will show all options. Imo, there is no need for more.

See the docstring for a list of required third-party packages.

Please report any bugs. I do not plan to add any enhancements.

Edward

[lewis]

Docstring needs updating - change line15 (and 19) from:

python -m leo.plugins.remove_duplicate_slides

to:

python -m leo.plugins.remove_duplicate_pictures

[Edward K. Ream]

On Fri, Jan 28, 2022 at 7:55 PM lewis <lewi...@fastmail.com.au> wrote:

Docstring needs updating

Thanks for this report.

Rev .31f45a5 in devel changes the docstring in three places and removes the unused 'c' positional arg from the run method.

Edward

[lewis]

Running externally works fine. However running in Leo as a script there are 3 issues.

Quit button does not work.
A single file is reported as a duplicate.
With a single file - if you rerun the script the number of duplicate files reported increments by 1.

Regards

Lewis

[tbp1...@gmail.com]

Probably because the class RemoveDuplicates initializes at import, not at initialization.  If the class gets reused, the global data variables get reused.  That works fine as a standalone, but not if reused inside Leo.

[Edward K. Ream]

On Sat, Jan 29, 2022 at 5:31 PM lewis <lewi...@fastmail.com.au> wrote:

Running externally works fine. However running in Leo as a script there are 3 issues.

Quit button does not work.
A single file is reported as a duplicate.
With a single file - if you rerun the script the number of duplicate files reported increments by 1.

Thanks for this report.  PR #2397 contains the fixes.

Edward