Leo 6.6.2b1 released without public announcements

[Edward K. Ream]

You should be able to ` pip install leo==6.6.2b1`.

The b1 release is strictly for private testing. The test-all command works for me.

Glitches

1. I mistakenly merged PR #2671 into the 6.6.2 branch from devel.  So now we get to test Thomas's new code :-)

2. pylint reports many errors, presumably because the rc file isn't in the right place.

3. mypy fails, saying that a typing module shadows the library module.

I don't plan to fix the pylint or mypy problems, now or ever.

Please report any other problems. I am going to release 6.6.2 on Friday, no matter what.

Edward

[Edward K. Ream]

On Monday, May 23, 2022 at 4:21:38 PM UTC-5 Edward K. Ream wrote:

1. I mistakenly merged PR #2671 into the 6.6.2 branch from devel.  So now we get to test Thomas's new code :-)

Rev d973bb in devel lower cases the 'file only' label, indicating that there is no Alt-Ctrl shortcut for it the radio button. 

Thomas, I don't see a toggle-find-file option in the PR #2665. For completeness it should probably exist, along with the typical Alt-Ctrl shortcuts. But we should leave all this for 6.6.3.  The more I think about this, the more I think I should (somehow!) undo the merge of the PR.  I'll try tomorrow when I have my wits about me :-)

Edward

[tbp1...@gmail.com]

No, I didn't realize there should be such a command.  I'll take a look at adding it (not for 6.6.2, of course!).

Please don't remove the code from devel even if you remove it from the release branch.  For a PR with the new command, I will have to have a fully merged branch that is otherwise up to date with devel, and if you remove the code from devel, it will wipe out mine.  That will make things much harder for me.

[tbp1...@gmail.com]

I just installed with pip and got 6.6.1.

[Edward K. Ream]

On Monday, May 23, 2022 at 5:30:41 PM UTC-5 tbp1...@gmail.com wrote:

I just installed with pip and got 6.6.1.

You have to do  `pip install leo==6.6.2b1`.  It works for me, and reports  Leo 6.6.2-b1 in the log.

Edward

[Edward K. Ream]

On Mon, May 23, 2022 at 4:56 PM tbp1...@gmail.com <tbp1...@gmail.com> wrote:

Please don't remove the code from devel even if you remove it from the release branch. 

Yes. That's my plan.

Edward

[tbp1...@gmail.com]

Actually, there should not be a toggle command because the control is a radiobutton.  It should a "set" command. And I already provide a set-find-file-only command in LeoFind.py:

@cmd('set-find-file-only')
def set_find_scope_file_only(self, event: Event=None) -> None:  # pragma: no cover (cmd)
    """Set the 'File Only' radio button in the Find tab."""
    self.set_find_scope('file-only')

So I think we're good.

On Monday, May 23, 2022 at 5:56:29 PM UTC-4 tbp1...@gmail.com wrote:

[Edward K. Ream]

On Tue, May 24, 2022 at 7:54 AM tbp1...@gmail.com <tbp1...@gmail.com> wrote:

Actually, there should not be a toggle command because the control is a radiobutton.  It should a "set" command. And I already provide a set-find-file-only command in LeoFind.py:

...

So I think we're good.

Two more tweaks complete the pattern:

- In leoSettings.leo, in the node "@shortcuts Find commands", we want to bind an Alt-Ctrl key to one of the remaining letters in "node only". So either Alt-Ctrl-L or Alt-Ctrl-Y.

- In the find pane itself, we should uppercase the chosen letter. (either "L" or "Y").

I'll do this myself.

Edward