I have reopened #1563

56 views
Skip to first unread message

Edward K. Ream

unread,
May 15, 2020, 11:19:19 AM5/15/20
to leo-editor
Rev 3fc316a in devel backs out of the proposed fix for #1563. The fix failed for Shift-Tab, commonly bound to unindent-region.

I suspect some new machinery/hack will be needed to handle German keyboards. This can't wait for a grand rewrite of the key code. In fact, the new code is likely to be needed in any case.

Edward

Edward K. Ream

unread,
May 16, 2020, 10:56:49 AM5/16/20
to leo-editor
On Friday, May 15, 2020 at 10:19:19 AM UTC-5, Edward K. Ream wrote:

Rev 3fc316a in devel backs out of the proposed fix for #1563. The fix failed for Shift-Tab, commonly bound to unindent-region.

Rev 0a5f036 in devel attempts the most minimal fix. It looks like only the colon and semicolon keys have an extra "Shift" modifier, which I guess is a good thing ;-)

Please report any further problems immediately. I have just closed #1563 yet again.

Edward

Edward K. Ream

unread,
May 17, 2020, 8:49:36 AM5/17/20
to leo-editor
On Saturday, May 16, 2020 at 9:56:49 AM UTC-5, Edward K. Ream wrote:

> Rev 0a5f036 in devel attempts the most minimal fix.

I have just reopened #1563. The present fix makes it impossible to bind commands to shift-colon or shift-semicolon on non-German keyboards. Someone who has a binding to shift-colon or shift-semicolon might not realize it doesn't work for months or even years.

filter.doAltTweaks should remove the shift modifier for colon and semicolons only for German keyboards, which means that Leo must support something like @bool use-german-keyboard.

Edward

Viktor Ransmayr

unread,
May 17, 2020, 2:27:58 PM5/17/20
to leo-e...@googlegroups.com
Hello Edward,

Am So., 17. Mai 2020 um 14:49 Uhr schrieb Edward K. Ream <edre...@gmail.com>:
On Saturday, May 16, 2020 at 9:56:49 AM UTC-5, Edward K. Ream wrote:

> Rev 0a5f036 in devel attempts the most minimal fix.

I have just reopened #1563. The present fix makes it impossible to bind commands to shift-colon or shift-semicolon on non-German keyboards. Someone who has a binding to shift-colon or shift-semicolon might not realize it doesn't work for months or even years.

I've installed your previous attempt to resolve the issue locally on my system - and - was trying to come up with tasks/tests that I could perform to help. - I failed (as a Leo user) ...

Is it possible that this issue no longer reflects the initial (much simpler) user problem?

With kind regards,

Viktor


Edward K. Ream

unread,
May 18, 2020, 7:25:03 AM5/18/20
to leo-editor
On Sun, May 17, 2020 at 1:27 PM Viktor Ransmayr <viktor....@gmail.com> wrote:

> I've installed your previous attempt to resolve the issue locally on my system - and - was trying to come up with tasks/tests that I could perform to help. - I failed (as a Leo user) ...

If I understand you correctly, you were satisfied with my previous fix. I backed out of that fix, so the present code will not work for you. I intend to fix the issue today, by adding a new setting.

> Is it possible that this issue no longer reflects the initial (much simpler) user problem?

No. The code involved has always been confined to filter.doAltTweaks.

The fix will involve a tweak only to colons and semicolons (shift-comma and shift-period). This fix will be in effect only when the new setting tells Leo that you are using a German keyboard.

Edward

Edward K. Ream

unread,
May 18, 2020, 7:56:13 AM5/18/20
to leo-editor
On Monday, May 18, 2020 at 6:25:03 AM UTC-5, Edward K. Ream wrote:

> The fix will involve a tweak only to colons and semicolons (shift-comma and shift-period). This fix will be in effect only when the new setting tells Leo that you are using a German keyboard.

Done at rev e7f2e02 in devel. All my hand tests pass.

The new setting is @bool use-german-keyboard, with False as the default. You should set it to True when using a German keyboard.

Edward
Reply all
Reply to author
Forward
0 new messages